Merge branch 'main' into adds-org-name-to-alert-emails

samejr · web-flow · commit ef7e9763507d · 2024-12-19T09:26:37.000Z
diff --git a/.changeset/fuzzy-coins-cross.md b/.changeset/fuzzy-coins-cross.md
diff --git a/.changeset/kind-plants-tap.md b/.changeset/kind-plants-tap.md
@@ -0,0 +1,5 @@
+---
+"trigger.dev": patch
+---
+
+Fix externals from monorepo packages with scoped package names #1552
diff --git a/.changeset/rude-walls-help.md b/.changeset/rude-walls-help.md
diff --git a/apps/webapp/app/v3/services/expireEnqueuedRun.server.ts b/apps/webapp/app/v3/services/expireEnqueuedRun.server.ts
@@ -49,6 +49,14 @@ export class ExpireEnqueuedRunService extends BaseService {
       return;
     }
 
+    if (run.lockedAt) {
+      logger.debug("Run cannot be expired because it's locked", {
+        run,
+      });
+
+      return;
+    }
+
     logger.debug("Expiring enqueued run", {
       run,
     });
diff --git a/docs/guides/examples/scrape-hacker-news.mdx b/docs/guides/examples/scrape-hacker-news.mdx
@@ -1,6 +1,6 @@
 ---
 title: "Scrape the top 3 articles from Hacker News and email yourself a summary every weekday"
-sidebarTitle: "Scrape Hacker News"
+sidebarTitle: "Browserbase & Puppeteer"
 description: "This example demonstrates how to scrape the top 3 articles from Hacker News using BrowserBase and Puppeteer, summarize them with ChatGPT and send a nicely formatted email summary to yourself every weekday using Resend."
 ---
 
diff --git a/docs/limits.mdx b/docs/limits.mdx
@@ -54,7 +54,7 @@ If you're creating schedules for your user you will definitely need to request m
 | Limit                  | Details                                       |
 | :--------------------- | :-------------------------------------------- |
 | Single trigger payload | Must not exceed 3MB                           |
-| Batch trigger payload  | The total of all payloads must not exceed 1MB |
+| Batch trigger payload  | The total of all payloads must not exceed 5MB |
 | Task outputs           | Must not exceed 10MB                          |
 
 Payloads and outputs that exceed 512KB will be offloaded to object storage and a presigned URL will be provided to download the data when calling `runs.retrieve`. You don't need to do anything to handle this in your tasks however, as we will transparently upload/download these during operation.
diff --git a/packages/build/CHANGELOG.md b/packages/build/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @trigger.dev/build
 
+## 3.3.7
+
+### Patch Changes
+
+- Updated dependencies:
+  - `@trigger.dev/core@3.3.7`
+
 ## 3.3.6
 
 ### Patch Changes
diff --git a/packages/build/package.json b/packages/build/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@trigger.dev/build",
-  "version": "3.3.6",
+  "version": "3.3.7",
   "description": "trigger.dev build extensions",
   "license": "MIT",
   "publishConfig": {
@@ -65,7 +65,7 @@
     "check-exports": "attw --pack ."
   },
   "dependencies": {
-    "@trigger.dev/core": "workspace:3.3.6",
+    "@trigger.dev/core": "workspace:3.3.7",
     "pkg-types": "^1.1.3",
     "tinyglobby": "^0.2.2",
     "tsconfck": "3.1.3"
diff --git a/packages/cli-v3/CHANGELOG.md b/packages/cli-v3/CHANGELOG.md
@@ -1,5 +1,13 @@
 # trigger.dev
 
+## 3.3.7
+
+### Patch Changes
+
+- Updated dependencies:
+  - `@trigger.dev/build@3.3.7`
+  - `@trigger.dev/core@3.3.7`
+
 ## 3.3.6
 
 ### Patch Changes
diff --git a/packages/cli-v3/package.json b/packages/cli-v3/package.json
@@ -1,6 +1,6 @@
 {
   "name": "trigger.dev",
-  "version": "3.3.6",
+  "version": "3.3.7",
   "description": "A Command-Line Interface for Trigger.dev (v3) projects",
   "type": "module",
   "license": "MIT",
@@ -87,8 +87,8 @@
     "@opentelemetry/sdk-trace-base": "1.25.1",
     "@opentelemetry/sdk-trace-node": "1.25.1",
     "@opentelemetry/semantic-conventions": "1.25.1",
-    "@trigger.dev/build": "workspace:3.3.6",
-    "@trigger.dev/core": "workspace:3.3.6",
+    "@trigger.dev/build": "workspace:3.3.7",
+    "@trigger.dev/core": "workspace:3.3.7",
     "c12": "^1.11.1",
     "chalk": "^5.2.0",
     "cli-table3": "^0.6.3",
diff --git a/packages/cli-v3/src/build/externals.ts b/packages/cli-v3/src/build/externals.ts
@@ -45,6 +45,27 @@ async function linkExternal(external: CollectedExternal, resolveDir: string, log
     external,
   });
 
+  // For scoped packages, we need to ensure the scope directory exists
+  if (external.name.startsWith("@")) {
+    // Get the scope part (e.g., '@huggingface')
+    const scopeDir = external.name.split("/")[0];
+
+    if (scopeDir) {
+      const scopePath = join(destinationPath, scopeDir);
+
+      logger.debug("[externals] Ensure scope directory exists", {
+        scopeDir,
+        scopePath,
+      });
+
+      await mkdir(scopePath, { recursive: true });
+    } else {
+      logger.debug("[externals] Unable to get the scope directory", {
+        external,
+      });
+    }
+  }
+
   const symbolicLinkPath = join(destinationPath, external.name);
 
   // Make sure the symbolic link does not exist
diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md
@@ -1,5 +1,7 @@
 # internal-platform
 
+## 3.3.7
+
 ## 3.3.6
 
 ### Patch Changes
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@trigger.dev/core",
-  "version": "3.3.6",
+  "version": "3.3.7",
   "description": "Core code used across the Trigger.dev SDK and platform",
   "license": "MIT",
   "publishConfig": {
diff --git a/packages/react-hooks/CHANGELOG.md b/packages/react-hooks/CHANGELOG.md
@@ -1,5 +1,17 @@
 # @trigger.dev/react-hooks
 
+## 3.3.7
+
+### Patch Changes
+
+- Now compatible with React 19 ([#1559](https://github.com/triggerdotdev/trigger.dev/pull/1559))
+- - Fixes an issue in streams where "chunks" could get split across multiple reads ([#1549](https://github.com/triggerdotdev/trigger.dev/pull/1549))
+  - Fixed stopping the run subscription after a run is finished, when using useRealtimeRun or useRealtimeRunWithStreams
+  - Added an `onComplete` callback to `useRealtimeRun` and `useRealtimeRunWithStreams`
+  - Optimized the run subscription to reduce unnecessary updates
+- Updated dependencies:
+  - `@trigger.dev/core@3.3.7`
+
 ## 3.3.6
 
 ### Patch Changes
diff --git a/packages/react-hooks/package.json b/packages/react-hooks/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@trigger.dev/react-hooks",
-  "version": "3.3.6",
+  "version": "3.3.7",
   "description": "trigger.dev react hooks",
   "license": "MIT",
   "publishConfig": {
@@ -37,7 +37,7 @@
     "check-exports": "attw --pack ."
   },
   "dependencies": {
-    "@trigger.dev/core": "workspace:^3.3.6",
+    "@trigger.dev/core": "workspace:^3.3.7",
     "swr": "^2.2.5"
   },
   "devDependencies": {
diff --git a/packages/rsc/CHANGELOG.md b/packages/rsc/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @trigger.dev/rsc
 
+## 3.3.7
+
+### Patch Changes
+
+- Updated dependencies:
+  - `@trigger.dev/core@3.3.7`
+
 ## 3.3.6
 
 ### Patch Changes
diff --git a/packages/rsc/package.json b/packages/rsc/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@trigger.dev/rsc",
-  "version": "3.3.6",
+  "version": "3.3.7",
   "description": "trigger.dev rsc",
   "license": "MIT",
   "publishConfig": {
@@ -37,14 +37,14 @@
     "check-exports": "attw --pack ."
   },
   "dependencies": {
-    "@trigger.dev/core": "workspace:^3.3.6",
+    "@trigger.dev/core": "workspace:^3.3.7",
     "mlly": "^1.7.1",
     "react": "19.0.0-rc.1",
     "react-dom": "19.0.0-rc.1"
   },
   "devDependencies": {
     "@arethetypeswrong/cli": "^0.15.4",
-    "@trigger.dev/build": "workspace:^3.3.6",
+    "@trigger.dev/build": "workspace:^3.3.7",
     "@types/node": "^20.14.14",
     "@types/react": "*",
     "@types/react-dom": "*",
diff --git a/packages/trigger-sdk/CHANGELOG.md b/packages/trigger-sdk/CHANGELOG.md
@@ -1,5 +1,16 @@
 # @trigger.dev/sdk
 
+## 3.3.7
+
+### Patch Changes
+
+- - Fixes an issue in streams where "chunks" could get split across multiple reads ([#1549](https://github.com/triggerdotdev/trigger.dev/pull/1549))
+  - Fixed stopping the run subscription after a run is finished, when using useRealtimeRun or useRealtimeRunWithStreams
+  - Added an `onComplete` callback to `useRealtimeRun` and `useRealtimeRunWithStreams`
+  - Optimized the run subscription to reduce unnecessary updates
+- Updated dependencies:
+  - `@trigger.dev/core@3.3.7`
+
 ## 3.3.6
 
 ### Patch Changes
diff --git a/packages/trigger-sdk/package.json b/packages/trigger-sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@trigger.dev/sdk",
-  "version": "3.3.6",
+  "version": "3.3.7",
   "description": "trigger.dev Node.JS SDK",
   "license": "MIT",
   "publishConfig": {
@@ -48,7 +48,7 @@
     "@opentelemetry/api": "1.9.0",
     "@opentelemetry/api-logs": "0.52.1",
     "@opentelemetry/semantic-conventions": "1.25.1",
-    "@trigger.dev/core": "workspace:3.3.6",
+    "@trigger.dev/core": "workspace:3.3.7",
     "chalk": "^5.2.0",
     "cronstrue": "^2.21.0",
     "debug": "^4.3.4",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"trigger.dev": patch
 +---
++
 +Fix externals from monorepo packages with scoped package names #1552
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@trigger.dev/core",`
`3`		`- "version": "3.3.6",`
	`3`	`+ "version": "3.3.7",`
`4`	`4`	`"description": "Core code used across the Trigger.dev SDK and platform",`
`5`	`5`	`"license": "MIT",`
`6`	`6`	`"publishConfig": {`