Skip to content

Commit f58dee1

Browse files
committed
Fix the task run status reason UI
1 parent de5e0c8 commit f58dee1

File tree

2 files changed

+7
-13
lines changed
  • apps/webapp/app
    • components/runs/v3
    • routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam.spans.$spanParam

2 files changed

+7
-13
lines changed

apps/webapp/app/components/runs/v3/TaskRunStatus.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,20 +93,17 @@ export function descriptionForTaskRunStatus(status: TaskRunStatus): string {
9393

9494
export function TaskRunStatusCombo({
9595
status,
96-
statusReason,
9796
className,
9897
iconClassName,
9998
}: {
10099
status: TaskRunStatus;
101-
statusReason?: string;
102100
className?: string;
103101
iconClassName?: string;
104102
}) {
105103
return (
106104
<span className={cn("flex items-center gap-1", className)}>
107105
<TaskRunStatusIcon status={status} className={cn("h-4 w-4", iconClassName)} />
108106
<TaskRunStatusLabel status={status} />
109-
<TaskRunStatusReason status={status} statusReason={statusReason} />
110107
</span>
111108
);
112109
}
@@ -120,7 +117,7 @@ const statusReasonsToDescription: Record<string, string> = {
120117
BACKGROUND_WORKER_MISMATCH: "Background worker mismatch",
121118
};
122119

123-
function TaskRunStatusReason({
120+
export function TaskRunStatusReason({
124121
status,
125122
statusReason,
126123
}: {
@@ -142,7 +139,7 @@ function TaskRunStatusReason({
142139
}
143140

144141
return (
145-
<Callout to="https://trigger.dev/docs" variant="warning" className="w-fit text-sm">
142+
<Callout to="https://trigger.dev/docs" variant="warning" className="text-sm">
146143
{description}
147144
</Callout>
148145
);

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam.spans.$spanParam/route.tsx

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ import { RunTag } from "~/components/runs/v3/RunTag";
4747
import { SpanEvents } from "~/components/runs/v3/SpanEvents";
4848
import { SpanTitle } from "~/components/runs/v3/SpanTitle";
4949
import { TaskRunAttemptStatusCombo } from "~/components/runs/v3/TaskRunAttemptStatus";
50-
import { TaskRunStatusCombo } from "~/components/runs/v3/TaskRunStatus";
50+
import { TaskRunStatusCombo, TaskRunStatusReason } from "~/components/runs/v3/TaskRunStatus";
5151
import { useOrganization } from "~/hooks/useOrganizations";
5252
import { useProject } from "~/hooks/useProject";
5353
import { useSearchParams } from "~/hooks/useSearchParam";
@@ -402,7 +402,7 @@ function RunBody({
402402
<Property.Item>
403403
<Property.Label>Status</Property.Label>
404404
<Property.Value>
405-
<TaskRunStatusCombo status={run.status} statusReason={run.statusReason} />
405+
<TaskRunStatusCombo status={run.status} />
406406
</Property.Value>
407407
</Property.Item>
408408
<Property.Item>
@@ -712,12 +712,9 @@ function RunBody({
712712
</div>
713713
) : (
714714
<div className="flex flex-col gap-4 pt-3">
715-
<div className="border-b border-grid-bright pb-3">
716-
<TaskRunStatusCombo
717-
status={run.status}
718-
statusReason={run.statusReason}
719-
className="text-sm"
720-
/>
715+
<div className="space-y-2 border-b border-grid-bright pb-3">
716+
<TaskRunStatusCombo status={run.status} className="text-sm" />
717+
<TaskRunStatusReason status={run.status} statusReason={run.statusReason} />
721718
</div>
722719
<RunTimeline run={run} />
723720

0 commit comments

Comments
 (0)