Skip to content

Commit f9caa9f

Browse files
committed
Added <tr> back to the main Table compontent
1 parent 4ab3f3c commit f9caa9f

File tree

2 files changed

+30
-33
lines changed
  • apps/webapp/app
    • components/primitives
    • routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.batches

2 files changed

+30
-33
lines changed

apps/webapp/app/components/primitives/Table.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,8 @@ export const TableHeader = forwardRef<HTMLTableSectionElement, TableHeaderProps>
4444
"sticky top-0 z-10 bg-background-dimmed after:absolute after:bottom-0 after:left-0 after:right-0 after:h-px after:bg-grid-bright",
4545
className
4646
)}
47-
tabIndex={-1}
4847
>
49-
{children}
48+
<tr tabIndex={-1}>{children}</tr>
5049
</thead>
5150
);
5251
}

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.batches/route.tsx

Lines changed: 29 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -134,38 +134,36 @@ function BatchesTable({ batches, hasFilters, filters }: BatchList) {
134134
return (
135135
<Table className="max-h-full overflow-y-auto">
136136
<TableHeader>
137-
<TableRow>
138-
<TableHeaderCell>ID</TableHeaderCell>
139-
<TableHeaderCell>Env</TableHeaderCell>
140-
<TableHeaderCell
141-
tooltip={
142-
<div className="flex flex-col divide-y divide-grid-dimmed">
143-
{allBatchStatuses.map((status) => (
144-
<div
145-
key={status}
146-
className="grid grid-cols-[8rem_1fr] gap-x-2 py-2 first:pt-1 last:pb-1"
147-
>
148-
<div className="mb-0.5 flex items-center gap-1.5 whitespace-nowrap">
149-
<BatchStatusCombo status={status} />
150-
</div>
151-
<Paragraph variant="extra-small" className="!text-wrap text-text-dimmed">
152-
{descriptionForBatchStatus(status)}
153-
</Paragraph>
137+
<TableHeaderCell>ID</TableHeaderCell>
138+
<TableHeaderCell>Env</TableHeaderCell>
139+
<TableHeaderCell
140+
tooltip={
141+
<div className="flex flex-col divide-y divide-grid-dimmed">
142+
{allBatchStatuses.map((status) => (
143+
<div
144+
key={status}
145+
className="grid grid-cols-[8rem_1fr] gap-x-2 py-2 first:pt-1 last:pb-1"
146+
>
147+
<div className="mb-0.5 flex items-center gap-1.5 whitespace-nowrap">
148+
<BatchStatusCombo status={status} />
154149
</div>
155-
))}
156-
</div>
157-
}
158-
>
159-
Status
160-
</TableHeaderCell>
161-
<TableHeaderCell>Runs</TableHeaderCell>
162-
<TableHeaderCell>Duration</TableHeaderCell>
163-
<TableHeaderCell>Created</TableHeaderCell>
164-
<TableHeaderCell>Finished</TableHeaderCell>
165-
<TableHeaderCell>
166-
<span className="sr-only">Go to batch</span>
167-
</TableHeaderCell>
168-
</TableRow>
150+
<Paragraph variant="extra-small" className="!text-wrap text-text-dimmed">
151+
{descriptionForBatchStatus(status)}
152+
</Paragraph>
153+
</div>
154+
))}
155+
</div>
156+
}
157+
>
158+
Status
159+
</TableHeaderCell>
160+
<TableHeaderCell>Runs</TableHeaderCell>
161+
<TableHeaderCell>Duration</TableHeaderCell>
162+
<TableHeaderCell>Created</TableHeaderCell>
163+
<TableHeaderCell>Finished</TableHeaderCell>
164+
<TableHeaderCell>
165+
<span className="sr-only">Go to batch</span>
166+
</TableHeaderCell>
169167
</TableHeader>
170168
<TableBody>
171169
{batches.length === 0 && !hasFilters ? (

0 commit comments

Comments
 (0)