Skip to content

Feat: do we fancy a native Astro integration? #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lirantal opened this issue Aug 16, 2023 · 6 comments
Closed

Feat: do we fancy a native Astro integration? #345

lirantal opened this issue Aug 16, 2023 · 6 comments
Labels
area/integrations enhancement New feature or request

Comments

@lirantal
Copy link
Contributor

lirantal commented Aug 16, 2023

Hey folks!

Similar to the Express and Next.js packages, do we want to have a native Astro integration package as part of the officially provided packages from Trigger.dev?

See the following resources for more context:

Of course, that would be amazing! Here's everything I can think of at the moment that would be nice to do to get astro support in (this isn't to say you should do these, just that they should be done at some point):

### Tasks
- [x] #354 Add astro adapter package to packages in the monorepo as @trigger.dev/astro
- [ ] https://github.com/triggerdotdev/examples/pull/5 Add example Astro project to the examples repo: https://github.com/triggerdotdev/examples
- [x] Add a Quick start guide to the Trigger.dev/docs
- [x] Add support for astro in @trigger.dev/cli init
@maige-app maige-app bot added enhancement New feature or request area/integrations labels Aug 16, 2023
@ericallam
Copy link
Member

ericallam commented Aug 16, 2023

Of course, that would be amazing! Here's everything I can think of at the moment that would be nice to do to get astro support in (this isn't to say you should do these, just that they should be done at some point):

@lirantal
Copy link
Contributor Author

Sounds like a good list. I might just tackle them as one-by-one PRs to make it scoped and easier to review and iterate while working to land these in officially.

@lirantal
Copy link
Contributor Author

@ericallam I think you can remove the bullet-list you created as I copied it over to my opening comment body as a tasklist so it is easier to track.

On that note, see first PR introduced for the astro package.

@ericallam
Copy link
Member

@lirantal I detailed in a github discussion here all the steps it would take to "officially" support another framework for Trigger.dev, thought you might find it interesting for the Astro work.

@lirantal
Copy link
Contributor Author

lirantal commented Oct 1, 2023

Looks like this is now already shipped thanks to:

So I'd imagine we can close?

@matt-aitken
Copy link
Member

@lirantal yep this is done, thanks a lot 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants