Skip to content

Commit 3dd04c5

Browse files
committed
Fix "metrics not supported error" when building with TRITON_ENABLE_METRICS=OFF flag
1 parent 979dc02 commit 3dd04c5

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

src/model.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,20 @@ def initialize(self, args):
109109
)
110110
self.output_dtype = pb_utils.triton_string_to_numpy(output_config["data_type"])
111111

112+
# Create vLLM custom metrics
113+
try:
114+
labels = {
115+
"model": self.args["model_name"],
116+
"version": self.args["model_version"],
117+
}
118+
self.metrics = VllmStatLogger(labels=labels)
119+
except pb_utils.TritonModelException as e:
120+
if "metrics not supported" in str(e):
121+
# Metrics are disabled at the server
122+
self.metrics = None
123+
else:
124+
raise e
125+
112126
# Prepare vLLM engine
113127
self.init_engine()
114128

@@ -153,15 +167,9 @@ def init_engine(self):
153167
AsyncEngineArgs(**self.vllm_engine_config)
154168
)
155169

156-
# If TRITON_ENABLE_METRICS<_CPU/_GPU> build flag is enabled.
157-
if self.args["metrics_mode"] in ["all", "cpu", "gpu"]:
158-
# Create vLLM custom Metrics
159-
labels = {
160-
"model": self.args["model_name"],
161-
"version": self.args["model_version"],
162-
}
163-
logger = VllmStatLogger(labels=labels)
164-
self.llm_engine.add_logger("triton", logger)
170+
# Add vLLM custom metrics
171+
if not self.metrics:
172+
self.llm_engine.add_logger("triton", self.metrics)
165173

166174
def setup_lora(self):
167175
self.enable_lora = False

0 commit comments

Comments
 (0)