Resolve comments

Author: yinggeh

README.md

@@ -110,10 +110,11 @@ In this case, please install vLLM first. You can do so by running
 container with the following commands:
 
 ```
-mkdir -p /opt/tritonserver/backends/vllm
-git clone https://github.com/triton-inference-server/vllm_backend.git /opt/tritonserver/backends/vllm/vllm_backend
-cp -r /opt/tritonserver/backends/vllm/vllm_backend/src/* /opt/tritonserver/backends/vllm
-rm -rf /opt/tritonserver/backends/vllm/vllm_backend
+vllm_tmp_dir=/tmp/backends/vllm_backend
+mkdir -p /opt/tritonserver/backends/vllm $vllm_tmp_dir
+git clone https://github.com/triton-inference-server/vllm_backend.git $vllm_tmp_dir
+cp -r $vllm_tmp_dir/src/* /opt/tritonserver/backends/vllm
+rm -rf $vllm_tmp_dir
 ```
 
 ## Using the vLLM Backend

src/model.py

@@ -159,19 +159,15 @@ def init_engine(self):
                     "model": self.args["model_name"],
                     "version": self.args["model_version"],
                 }
-                self.metrics = VllmStatLogger(labels=labels)
+                # Add vLLM custom metrics
+                self.llm_engine.add_logger("triton", VllmStatLogger(labels=labels))
             except pb_utils.TritonModelException as e:
                 if "metrics not supported" in str(e):
                     # Metrics are disabled at the server
-                    self.metrics = None
                     self.logger.log_info("[vllm] Metrics not supported")
                 else:
                     raise e
 
-            # Add vLLM custom metrics
-            if self.metrics:
-                self.llm_engine.add_logger("triton", self.metrics)
-
     def setup_lora(self):
         self.enable_lora = False
 

src/utils/metrics.py

@@ -67,7 +67,7 @@ def __init__(self, labels: Dict, local_interval: float = 0) -> None:
         self.metrics = TritonMetrics(labels=labels)
 
     def info(self, type: str, obj: SupportsMetricsInfo) -> None:
-        raise NotImplementedError
+        pass
 
     def _log_counter(self, counter, data: Union[int, float]) -> None:
         """Convenience function for logging to counter.