V4 Signer (#36)

* Add a VM- and WebWorker-safe way to check if an object is an ArrayBuffer

* Document expectations on headers and querystring params

* WIP commit

* WIP commit

* Add a node stream collector

* Add a hex encoding package

* Add tests for getCanonicalQuery

* Add tests for getPayloadHash

* Remove dependency on and use of stream collectors. Streams should be considered always unsignable

* Add tests to fully cover SignatureV4::signRequest

* Remove unused packages

* Update RequestSigner interface to take keywords args instead of positional arguments

* Add presigner and functional and unit tests

* Cover the last uncovered line of code

* Allow the set of unsignable headers to be customized

Author: jeskew

packages/crypto-sha256-node/index.ts

@@ -32,9 +32,9 @@ function castSourceData(toCast: SourceData, encoding?: string): Buffer {
     return fromString(toCast, encoding);
   }
 
-  if (toCast instanceof ArrayBuffer) {
-    return fromArrayBuffer(toCast);
+  if (ArrayBuffer.isView(toCast)) {
+    return fromArrayBuffer(toCast.buffer, toCast.byteOffset, toCast.byteLength);
   }
 
-  return fromArrayBuffer(toCast.buffer, toCast.byteOffset, toCast.byteLength);
+  return fromArrayBuffer(toCast);
 }

packages/crypto-sha256-node/tsconfig.json

@@ -3,8 +3,8 @@
      "target": "es5",
      "module": "commonjs",
      "lib": [
-       "ES5",
-       "ES2015.Promise"
+       "es5",
+       "es2015.promise"
      ],
      "declaration": true,
      "sourceMap": true,

packages/is-array-buffer/.gitignore

@@ -0,0 +1,3 @@
+*.js
+*.js.map
+*.d.ts

packages/is-array-buffer/__tests__/index.ts

@@ -0,0 +1,34 @@
+import { isArrayBuffer } from "../";
+
+describe("isArrayBuffer", () => {
+  const arrayBufferConstructor = ArrayBuffer;
+
+  afterEach(() => {
+    (ArrayBuffer as any) = arrayBufferConstructor;
+  });
+
+  it("should return true for ArrayBuffer objects", () => {
+    expect(isArrayBuffer(new ArrayBuffer(0))).toBe(true);
+  });
+
+  it("should return false for ArrayBufferView objects", () => {
+    const view = new Uint8Array(0);
+
+    expect(isArrayBuffer(view)).toBe(false);
+    expect(isArrayBuffer(view.buffer)).toBe(true);
+  });
+
+  it("should return false for scalar values", () => {
+    for (let scalar of ["string", 123.234, true, null, void 0]) {
+      expect(isArrayBuffer(scalar)).toBe(false);
+    }
+  });
+
+  it("should return true for ArrayBuffers created with a different instance of the ArrayBuffer constructor", () => {
+    const buffer = new ArrayBuffer(0);
+    (ArrayBuffer as any) = () => buffer;
+
+    expect(buffer).not.toBeInstanceOf(ArrayBuffer);
+    expect(isArrayBuffer(buffer)).toBe(true);
+  });
+});

packages/is-array-buffer/index.ts

@@ -0,0 +1,7 @@
+export function isArrayBuffer(arg: any): arg is ArrayBuffer {
+  return (
+    typeof ArrayBuffer === "function" &&
+    (arg instanceof ArrayBuffer ||
+      Object.prototype.toString.call(arg) === "[object ArrayBuffer]")
+  );
+}

packages/is-array-buffer/package.json

@@ -0,0 +1,19 @@
+{
+  "name": "@aws/is-array-buffer",
+  "private": true,
+  "version": "0.0.1",
+  "description": "Provides a function for detecting if an argument is an ArrayBuffer",
+  "scripts": {
+    "pretest": "tsc",
+    "test": "jest"
+  },
+  "author": "[email protected]",
+  "license": "UNLICENSED",
+  "main": "index.js",
+  "devDependencies": {
+    "@types/jest": "^20.0.2",
+    "@types/node": "^7.0.12",
+    "jest": "^20.0.4",
+    "typescript": "^2.3"
+  }
+}

packages/is-array-buffer/tsconfig.json

@@ -0,0 +1,9 @@
+{
+  "compilerOptions": {
+    "target": "es5",
+    "module": "commonjs",
+    "declaration": true,
+    "strict": true,
+    "sourceMap": true
+  }
+}

packages/service-model/__fixtures__/index.ts

@@ -195,14 +195,12 @@ export function deepCopy<T>(arg: T): T {
   }
 
   if (typeof arg === "object") {
-    return <T>(
-      Object.keys(arg).reduce(
-        (carry: object, item: keyof T) => ({
-          ...carry,
-          [item]: deepCopy(arg[item])
-        }),
-        {}
-      )
+    return Object.keys(arg).reduce(
+      (carry: T, item: keyof T) => ({
+        ...(carry as any),
+        [item]: deepCopy(arg[item])
+      }),
+      {}
     );
   }
 

packages/signature-v4/.gitignore

@@ -0,0 +1,4 @@
+/node_modules/
+*.js
+*.js.map
+*.d.ts