Fix issue where chat history is saved redundantly #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the following issue:
a. Fills
self._chat_history
fromapp_session_data
.b. Retrieves a list of conversations up to
self._config["chat_history_limit"]
fromself._chat_history
.c. Appends the last retrieved conversation list to
self._agent_messages
(ultimately used for openai chat completion).finish_reason=stop
, it saveschat_history
toapp_session_data
asself._chat_history + self._agent_messages
. As a result, the conversation list obtained in b exists on both sides, leading to duplicate conversation storage.To solve this issue, when saving
app_session_data
, modify it to exclude conversations up tochat_history_limit
and save them to avoid unnecessary duplication.