Skip to content

Commit ffd84a6

Browse files
committed
[mlir] Fix -Wsign-compare in MemRefOps.cpp (NFC)
llvm-project/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp:2763:23: error: comparison of integers of different signs: 'int64_t' (aka 'long') and 'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare] assert(t1.getRank() == droppedDims.size() && "incorrect number of bits"); ~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~ llvm-project/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp:2764:38: error: comparison of integers of different signs: 'int64_t' (aka 'long') and 'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare] assert(t1.getRank() - t2.getRank() == droppedDims.count() && ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~
1 parent b5d35fe commit ffd84a6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2760,8 +2760,8 @@ static bool haveCompatibleOffsets(MemRefType t1, MemRefType t2) {
27602760
/// marked as dropped in `droppedDims`.
27612761
static bool haveCompatibleStrides(MemRefType t1, MemRefType t2,
27622762
const llvm::SmallBitVector &droppedDims) {
2763-
assert(t1.getRank() == droppedDims.size() && "incorrect number of bits");
2764-
assert(t1.getRank() - t2.getRank() == droppedDims.count() &&
2763+
assert(size_t(t1.getRank()) == droppedDims.size() && "incorrect number of bits");
2764+
assert(size_t(t1.getRank() - t2.getRank()) == droppedDims.count() &&
27652765
"incorrect number of dropped dims");
27662766
int64_t t1Offset, t2Offset;
27672767
SmallVector<int64_t> t1Strides, t2Strides;

0 commit comments

Comments
 (0)