platform/chrome: wilco_ec: use sysfs_emit() instead of sprintf()

TomAi0 · Tzung-Bi Shih · commit 48e49af7108b · 2024-04-24T16:45:56.000+08:00
Follow the advice in Documentation/filesystems/sysfs.rst: show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Ai Chao <aichao@kylinos.cn> Link: https://lore.kernel.org/r/20240314052828.186924-1-aichao@kylinos.cn Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
diff --git a/drivers/platform/chrome/wilco_ec/sysfs.c b/drivers/platform/chrome/wilco_ec/sysfs.c
@@ -192,7 +192,7 @@ static ssize_t usb_charge_show(struct device *dev,
 	if (ret < 0)
 		return ret;
 
-	return sprintf(buf, "%d\n", rs.val);
+	return sysfs_emit(buf, "%d\n", rs.val);
 }
 
 static ssize_t usb_charge_store(struct device *dev,

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ static ssize_t usb_charge_show(struct device *dev,`
`192`	`192`	`if (ret < 0)`
`193`	`193`	`return ret;`
`194`	`194`
`195`		`- return sprintf(buf, "%d\n", rs.val);`
	`195`	`+ return sysfs_emit(buf, "%d\n", rs.val);`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`static ssize_t usb_charge_store(struct device *dev,`