Skip to content

Commit 6423fc3

Browse files
sassmannJeff Kirsher
authored andcommitted
igb: do not re-init SR-IOV during probe
During driver probing the following code path is triggered. igb_probe ->igb_sw_init ->igb_probe_vfs ->igb_pci_enable_sriov ->igb_sriov_reinit Doing the SR-IOV re-init is not necessary during probing since we're starting from scratch. Here we can call igb_enable_sriov() right away. Running igb_sriov_reinit() during igb_probe() also seems to cause occasional packet loss on some onboard 82576 NICs. Reproduced on Dell and HP servers with onboard 82576 NICs. Example: Intel Corporation 82576 Gigabit Network Connection [8086:10c9] (rev 01) Subsystem: Dell Device [1028:0481] Signed-off-by: Stefan Assmann <[email protected]> Tested-by: Aaron Brown <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent f468adc commit 6423fc3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/intel/igb/igb_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2851,7 +2851,7 @@ static void igb_probe_vfs(struct igb_adapter *adapter)
28512851
return;
28522852

28532853
pci_sriov_set_totalvfs(pdev, 7);
2854-
igb_pci_enable_sriov(pdev, max_vfs);
2854+
igb_enable_sriov(pdev, max_vfs);
28552855

28562856
#endif /* CONFIG_PCI_IOV */
28572857
}

0 commit comments

Comments
 (0)