Skip to content

Commit 66ee363

Browse files
masahir0ybp3tk0v
authored andcommitted
x86/kconfig: Select ARCH_WANT_FRAME_POINTERS again when UNWINDER_FRAME_POINTER=y
It took me some time to understand the purpose of the tricky code at the end of arch/x86/Kconfig.debug. Without it, the following would be shown: WARNING: unmet direct dependencies detected for FRAME_POINTER because 81d3871 ("x86/kconfig: Consolidate unwinders into multiple choice selection") removed 'select ARCH_WANT_FRAME_POINTERS'. The correct and more straightforward approach should have been to move it where 'select FRAME_POINTER' is located. Several architectures properly handle the conditional selection of ARCH_WANT_FRAME_POINTERS. For example, 'config UNWINDER_FRAME_POINTER' in arch/arm/Kconfig.debug. Fixes: 81d3871 ("x86/kconfig: Consolidate unwinders into multiple choice selection") Signed-off-by: Masahiro Yamada <[email protected]> Signed-off-by: Borislav Petkov (AMD) <[email protected]> Acked-by: Josh Poimboeuf <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 9dba9c6 commit 66ee363

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

arch/x86/Kconfig.debug

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@ config UNWINDER_ORC
248248

249249
config UNWINDER_FRAME_POINTER
250250
bool "Frame pointer unwinder"
251+
select ARCH_WANT_FRAME_POINTERS
251252
select FRAME_POINTER
252253
help
253254
This option enables the frame pointer unwinder for unwinding kernel
@@ -271,7 +272,3 @@ config UNWINDER_GUESS
271272
overhead.
272273

273274
endchoice
274-
275-
config FRAME_POINTER
276-
depends on !UNWINDER_ORC && !UNWINDER_GUESS
277-
bool

0 commit comments

Comments
 (0)