Skip to content

Commit 706a9ad

Browse files
krzkroxanan1996
authored andcommitted
ARM: dts: samsung: s5pv210: fix camera unit addresses/ranges
BugLink: https://bugs.launchpad.net/bugs/2059284 [ Upstream commit 07e6a55 ] The camera node has both unit address and children within the same bus mapping, thus needs proper ranges property to fix dtc W=1 warnings: Warning (unit_address_vs_reg): /soc/camera@fa600000: node has a unit name, but no reg or ranges property Warning (simple_bus_reg): /soc/camera@fa600000: missing or empty reg/ranges property Subtract 0xfa600000 from all its children nodes. No functional impact expected. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Sasha Levin <[email protected]> Signed-off-by: Manuel Diewald <[email protected]> Signed-off-by: Stefan Bader <[email protected]>
1 parent dad9c62 commit 706a9ad

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

arch/arm/boot/dts/samsung/s5pv210.dtsi

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -549,17 +549,17 @@
549549

550550
camera: camera@fa600000 {
551551
compatible = "samsung,fimc";
552+
ranges = <0x0 0xfa600000 0xe01000>;
552553
clocks = <&clocks SCLK_CAM0>, <&clocks SCLK_CAM1>;
553554
clock-names = "sclk_cam0", "sclk_cam1";
554555
#address-cells = <1>;
555556
#size-cells = <1>;
556557
#clock-cells = <1>;
557558
clock-output-names = "cam_a_clkout", "cam_b_clkout";
558-
ranges;
559559

560-
csis0: csis@fa600000 {
560+
csis0: csis@0 {
561561
compatible = "samsung,s5pv210-csis";
562-
reg = <0xfa600000 0x4000>;
562+
reg = <0x00000000 0x4000>;
563563
interrupt-parent = <&vic2>;
564564
interrupts = <29>;
565565
clocks = <&clocks CLK_CSIS>,
@@ -572,9 +572,9 @@
572572
#size-cells = <0>;
573573
};
574574

575-
fimc0: fimc@fb200000 {
575+
fimc0: fimc@c00000 {
576576
compatible = "samsung,s5pv210-fimc";
577-
reg = <0xfb200000 0x1000>;
577+
reg = <0x00c00000 0x1000>;
578578
interrupts = <5>;
579579
interrupt-parent = <&vic2>;
580580
clocks = <&clocks CLK_FIMC0>,
@@ -586,9 +586,9 @@
586586
samsung,cam-if;
587587
};
588588

589-
fimc1: fimc@fb300000 {
589+
fimc1: fimc@d00000 {
590590
compatible = "samsung,s5pv210-fimc";
591-
reg = <0xfb300000 0x1000>;
591+
reg = <0x00d00000 0x1000>;
592592
interrupt-parent = <&vic2>;
593593
interrupts = <6>;
594594
clocks = <&clocks CLK_FIMC1>,
@@ -602,9 +602,9 @@
602602
samsung,lcd-wb;
603603
};
604604

605-
fimc2: fimc@fb400000 {
605+
fimc2: fimc@e00000 {
606606
compatible = "samsung,s5pv210-fimc";
607-
reg = <0xfb400000 0x1000>;
607+
reg = <0x00e00000 0x1000>;
608608
interrupt-parent = <&vic2>;
609609
interrupts = <7>;
610610
clocks = <&clocks CLK_FIMC2>,

0 commit comments

Comments
 (0)