Skip to content

Commit a34acf3

Browse files
urezkiakpm00
authored andcommitted
mm: vmalloc: check if a hash-index is in cpu_possible_mask
The problem is that there are systems where cpu_possible_mask has gaps between set CPUs, for example SPARC. In this scenario addr_to_vb_xa() hash function can return an index which accesses to not-possible and not setup CPU area using per_cpu() macro. This results in an oops on SPARC. A per-cpu vmap_block_queue is also used as hash table, incorrectly assuming the cpu_possible_mask has no gaps. Fix it by adjusting an index to a next possible CPU. Link: https://lkml.kernel.org/r/[email protected] Fixes: 062eacf ("mm: vmalloc: remove a global vmap_blocks xarray") Reported-by: Nick Bowler <[email protected]> Closes: https://lore.kernel.org/linux-kernel/ZntjIE6msJbF8zTa@MiWiFi-R3L-srv/T/ Signed-off-by: Uladzislau Rezki (Sony) <[email protected]> Reviewed-by: Baoquan He <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: Hailong.Liu <[email protected]> Cc: Oleksiy Avramchenko <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 82f0b6f commit a34acf3

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

mm/vmalloc.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2543,7 +2543,15 @@ static DEFINE_PER_CPU(struct vmap_block_queue, vmap_block_queue);
25432543
static struct xarray *
25442544
addr_to_vb_xa(unsigned long addr)
25452545
{
2546-
int index = (addr / VMAP_BLOCK_SIZE) % num_possible_cpus();
2546+
int index = (addr / VMAP_BLOCK_SIZE) % nr_cpu_ids;
2547+
2548+
/*
2549+
* Please note, nr_cpu_ids points on a highest set
2550+
* possible bit, i.e. we never invoke cpumask_next()
2551+
* if an index points on it which is nr_cpu_ids - 1.
2552+
*/
2553+
if (!cpu_possible(index))
2554+
index = cpumask_next(index, cpu_possible_mask);
25472555

25482556
return &per_cpu(vmap_block_queue, index).vmap_blocks;
25492557
}

0 commit comments

Comments
 (0)