Skip to content

Commit ac322f8

Browse files
wvk86davem330
authored andcommitted
net: stmmac: Fix clock handling on remove path
While unloading the dwmac-intel driver, clk_disable_unprepare() is being called twice in stmmac_dvr_remove() and intel_eth_pci_remove(). This causes kernel panic on the second call. Removing the second call of clk_disable_unprepare() in intel_eth_pci_remove(). Fixes: 09f012e ("stmmac: intel: Fix clock handling on error and remove paths") Cc: Andy Shevchenko <[email protected]> Reviewed-by: Voon Weifeng <[email protected]> Signed-off-by: Wong Vee Khee <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1dac3b1 commit ac322f8

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,6 @@ static void intel_eth_pci_remove(struct pci_dev *pdev)
653653

654654
pci_free_irq_vectors(pdev);
655655

656-
clk_disable_unprepare(priv->plat->stmmac_clk);
657656
clk_unregister_fixed_rate(priv->plat->stmmac_clk);
658657

659658
pcim_iounmap_regions(pdev, BIT(0));

0 commit comments

Comments
 (0)