Skip to content

Commit d9b00aa

Browse files
jmberg-intelsmb49
authored andcommitted
wifi: mac80211: fix SA Query processing in MLO
BugLink: https://bugs.launchpad.net/bugs/2110173 [ Upstream commit 9a267ce ] When MLO is used and SA Query processing isn't done by userspace (e.g. wpa_supplicant w/o CONFIG_OCV), then the mac80211 code kicks in but uses the wrong addresses. Fix them. Signed-off-by: Johannes Berg <[email protected]> Reviewed-by: Ilan Peer <[email protected]> Signed-off-by: Miri Korenblit <[email protected]> Link: https://patch.msgid.link/20250306123626.bab48bb49061.I9391b22f1360d20ac8c4e92604de23f27696ba8f@changeid Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Sasha Levin <[email protected]> Signed-off-by: Noah Wager <[email protected]> Signed-off-by: Stefan Bader <[email protected]>
1 parent 9eb8a0f commit d9b00aa

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

net/mac80211/rx.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* Copyright 2007-2010 Johannes Berg <[email protected]>
77
* Copyright 2013-2014 Intel Mobile Communications GmbH
88
* Copyright(c) 2015 - 2017 Intel Deutschland GmbH
9-
* Copyright (C) 2018-2024 Intel Corporation
9+
* Copyright (C) 2018-2025 Intel Corporation
1010
*/
1111

1212
#include <linux/jiffies.h>
@@ -3323,8 +3323,8 @@ static void ieee80211_process_sa_query_req(struct ieee80211_sub_if_data *sdata,
33233323
return;
33243324
}
33253325

3326-
if (!ether_addr_equal(mgmt->sa, sdata->deflink.u.mgd.bssid) ||
3327-
!ether_addr_equal(mgmt->bssid, sdata->deflink.u.mgd.bssid)) {
3326+
if (!ether_addr_equal(mgmt->sa, sdata->vif.cfg.ap_addr) ||
3327+
!ether_addr_equal(mgmt->bssid, sdata->vif.cfg.ap_addr)) {
33283328
/* Not from the current AP or not associated yet. */
33293329
return;
33303330
}
@@ -3340,9 +3340,9 @@ static void ieee80211_process_sa_query_req(struct ieee80211_sub_if_data *sdata,
33403340

33413341
skb_reserve(skb, local->hw.extra_tx_headroom);
33423342
resp = skb_put_zero(skb, 24);
3343-
memcpy(resp->da, mgmt->sa, ETH_ALEN);
3343+
memcpy(resp->da, sdata->vif.cfg.ap_addr, ETH_ALEN);
33443344
memcpy(resp->sa, sdata->vif.addr, ETH_ALEN);
3345-
memcpy(resp->bssid, sdata->deflink.u.mgd.bssid, ETH_ALEN);
3345+
memcpy(resp->bssid, sdata->vif.cfg.ap_addr, ETH_ALEN);
33463346
resp->frame_control = cpu_to_le16(IEEE80211_FTYPE_MGMT |
33473347
IEEE80211_STYPE_ACTION);
33483348
skb_put(skb, 1 + sizeof(resp->u.action.u.sa_query));

0 commit comments

Comments
 (0)