Fix 10k favs check #572
Closed
Fix 10k favs check #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It originally was check if it was greater than or equal to 1000. This commit would fix the issue by replacing 1000 with the correct number, 10000.
|
|
Comment on lines
162
to
+163
| "has_gte_10k_favs", | ||
| _.getOrElse(EarlybirdFeature, None).exists(_.favCountV2.exists(_ >= 1000))), | ||
| _.getOrElse(EarlybirdFeature, None).exists(_.favCountV2.exists(_ >= 10000))), |
There was a problem hiding this comment.
Use 10_000 to avoid clowning ourselves in the future
There was a problem hiding this comment.
Also add a test that would expose this bug.
|
I was actually expecting a joke PR, but seems to actually fix something 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It originally was check if it was greater than or equal to 1000. This commit would fix the issue by replacing 1000 with the correct number, 10000.