Skip to content

Commit e0ec43f

Browse files
authored
Fix HyperlinkedRelatedField.get_object() argument types (#597)
* Fix `HyperlinkedRelatedField.get_object()` argument types Upstream typehints this method as `def get_object(self, view_name, view_args, view_kwargs)` * Fix allowlist too
1 parent 9d25503 commit e0ec43f

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

rest_framework-stubs/relations.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ class HyperlinkedRelatedField(RelatedField[_MT, str, Hyperlink]):
129129
lookup_url_kwarg: str | None = ...,
130130
format: str | None = ...,
131131
) -> None: ...
132-
def get_object(self, view_name: str, *view_args: Any, **view_kwargs: Any) -> _MT: ...
132+
def get_object(self, view_name: str, view_args: list[Any], view_kwargs: dict[str, Any]) -> _MT: ...
133133
def get_url(self, obj: Model, view_name: str, request: Request, format: str | None) -> str | None: ...
134134

135135
class HyperlinkedIdentityField(HyperlinkedRelatedField): ...

scripts/stubtest/allowlist_todo.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ rest_framework.pagination.HtmlContext
5151
rest_framework.pagination.HtmlContextWithPageLinks
5252
rest_framework.parsers.BaseParser.media_type
5353
rest_framework.parsers.FileUploadParser.get_encoded_filename
54-
rest_framework.relations.HyperlinkedRelatedField.get_object
5554
rest_framework.relations.ManyRelatedField.initial
5655
rest_framework.relations.ManyRelatedField.to_representation
5756
rest_framework.relations.SlugRelatedField.to_representation
@@ -91,7 +90,6 @@ rest_framework.serializers.DateField.to_internal_value
9190
rest_framework.serializers.DateTimeField.to_internal_value
9291
rest_framework.serializers.DictField.initial
9392
rest_framework.serializers.DurationField.to_internal_value
94-
rest_framework.serializers.HyperlinkedRelatedField.get_object
9593
rest_framework.serializers.ListField.initial
9694
rest_framework.serializers.ListField.to_representation
9795
rest_framework.serializers.ListSerializer.is_valid

0 commit comments

Comments
 (0)