Skip to content
This repository was archived by the owner on Sep 1, 2020. It is now read-only.

Commit ff5619e

Browse files
committed
Cleanups involving name encoding and decoding.
1 parent b939e8f commit ff5619e

File tree

10 files changed

+14
-12
lines changed

10 files changed

+14
-12
lines changed

src/attic/scala/tools/nsc/models/SemanticTokens.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import scala.tools.nsc.Global
1414
import scala.tools.nsc.symtab.{Flags, Names}
1515
import scala.tools.nsc.symtab.Flags.DEFERRED
1616
import scala.tools.nsc.util.{BatchSourceFile, SourceFile}
17-
import scala.reflect.NameTransformer
1817

1918
class SemanticTokens(val compiler: Global) {
2019
import compiler._
@@ -160,7 +159,7 @@ class SemanticTokens(val compiler: Global) {
160159
else new Info(symbol)
161160

162161
abstract class Semantic(val symbol: Symbol) extends Actual {
163-
val name = NameTransformer.decode(symbol.name.toString).trim()
162+
val name = symbol.name.decode.toString.trim
164163
assert(symbol != NoSymbol)
165164
def myOuter = Process.this
166165

@@ -503,7 +502,7 @@ class SemanticTokens(val compiler: Global) {
503502
//Thread.dumpStack()
504503
}
505504
else if (term != NoSymbol) {
506-
val name = NameTransformer.decode(term.name.toString).trim()
505+
val name = term.name.decode.toString.trim
507506
val buf = unit.source.asInstanceOf[BatchSourceFile].content
508507
val cs = name.toChars
509508
var idx = 0

src/attic/scala/tools/nsc/models/Signatures.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import scala.collection.mutable.{HashMap, HashSet}
1010
import scala.tools.nsc.{Global => Compiler}
1111
import scala.tools.nsc.symtab.{Flags, Names}
1212
import scala.tools.nsc.util.{ Position, SourceFile }
13-
import scala.reflect.NameTransformer
1413

1514
/** This class ...
1615
*

src/compiler/scala/reflect/internal/Names.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
package scala.reflect
77
package internal
88

9-
import scala.reflect.NameTransformer
109
import scala.io.Codec
1110
import java.security.MessageDigest
1211

src/compiler/scala/tools/nsc/doc/html/HtmlPage.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import comment._
1313
import xml.{XML, NodeSeq}
1414
import xml.dtd.{DocType, PublicID}
1515
import scala.collection._
16-
import scala.reflect.NameTransformer
1716
import java.nio.channels.Channels
1817

1918
/** An html page that is part of a Scaladoc site.

src/compiler/scala/tools/nsc/interpreter/IMain.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import Exceptional.unwrap
2525
import scala.collection.{ mutable, immutable }
2626
import scala.PartialFunction.{ cond, condOpt }
2727
import scala.util.control.Exception.{ ultimately }
28-
import scala.reflect.NameTransformer
2928
import IMain._
3029

3130
/** An interpreter for Scala code.

src/compiler/scala/tools/nsc/interpreter/MemberHandlers.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ package interpreter
88

99
import scala.collection.{ mutable, immutable }
1010
import scala.PartialFunction.cond
11-
import scala.reflect.NameTransformer
1211
import scala.reflect.internal.Chars
1312

1413
trait MemberHandlers {
@@ -67,7 +66,7 @@ trait MemberHandlers {
6766
def name: Name = member.name
6867
def mods: Modifiers = member.mods
6968
def keyword = member.keyword
70-
def prettyName = NameTransformer.decode(name)
69+
def prettyName = name.decode
7170

7271
override def definesImplicit = member.mods.isImplicit
7372
override def definesTerm: Option[TermName] = Some(name.toTermName) filter (_ => name.isTermName)

src/compiler/scala/tools/nsc/interpreter/Power.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
package scala.tools.nsc
77
package interpreter
88

9-
import scala.reflect.{ NameTransformer, AnyValManifest }
9+
import scala.reflect.AnyValManifest
1010
import scala.collection.{ mutable, immutable }
1111
import scala.util.matching.Regex
1212
import scala.tools.nsc.util.{ BatchSourceFile }

src/compiler/scala/tools/nsc/interpreter/ReplStrings.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ package interpreter
88

99
import scala.collection.{ mutable, immutable }
1010
import scala.PartialFunction.cond
11-
import scala.reflect.NameTransformer
1211
import scala.reflect.internal.Chars
1312

1413
trait ReplStrings {

src/compiler/scala/tools/nsc/matching/Patterns.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ package scala.tools.nsc
77
package matching
88

99
import symtab.Flags
10-
import scala.reflect.NameTransformer.decode
1110
import PartialFunction._
1211

1312
/** Patterns are wrappers for Trees with enhanced semantics.

src/library/scala/reflect/api/Names.scala

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,16 @@ trait Names {
1212
def isTypeName: Boolean
1313
def toTermName: TermName
1414
def toTypeName: TypeName
15+
16+
/** Replace all occurrences of $op_names in this name by corresponding operator symbols.
17+
* Example: `foo_+=` becomes `foo_$plus$eq`.
18+
*/
19+
def decode: String
20+
21+
/** Replace all occurrences of operator symbols in this name by corresponding $op_names.
22+
* Example: `foo_$plus$eq` becomes `foo_+=`
23+
*/
24+
def encode: Name
1525
}
1626

1727
def newTermName(s: String): TermName

0 commit comments

Comments
 (0)