Update based on PR feedback

Author: rbuckton

src/compiler/factory.ts

@@ -3645,7 +3645,7 @@ namespace ts {
                         return { value: o && o[i++], done: !o };
                     }
                 };
-                throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+                throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
             };`
     };
 

src/testRunner/unittests/evaluation/forOf.ts

@@ -66,7 +66,7 @@ describe("unittests:: evaluation:: forOfEvaluation", () => {
         }
         `, { downlevelIteration: true, target: ts.ScriptTarget.ES5 });
 
-        assert.throws(() => result.main(), "undefined is not iterable (cannot read property Symbol(Symbol.iterator))");
+        assert.throws(() => result.main(), /cannot read property.*Symbol\(Symbol\.iterator\).*/i);
     });
 
     it("es5 over object with no Symbol.iterator with no Symbol", () => {
@@ -93,7 +93,7 @@ describe("unittests:: evaluation:: forOfEvaluation", () => {
         }
         `, { downlevelIteration: true, target: ts.ScriptTarget.ES5 });
 
-        assert.throws(() => result.main(), "Object not iterable");
+        assert.throws(() => result.main(), "Object is not iterable");
     });
 
     it("es5 over object with Symbol.iterator", () => {
@@ -110,7 +110,7 @@ describe("unittests:: evaluation:: forOfEvaluation", () => {
                 {
                     output.push(value)
                 }
-                
+
             }`, { downlevelIteration: true, target: ts.ScriptTarget.ES5 });
 
         result.main();

tests/baselines/reference/ES5For-of33.js

@@ -17,7 +17,7 @@ sourceFile:ES5For-of33.ts
 >>>            return { value: o && o[i++], done: !o };
 >>>        }
 >>>    };
->>>    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+>>>    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 >>>};
 >>>var e_1, _a;
 >>>try {

tests/baselines/reference/ES5For-of33.sourcemap.txt

@@ -17,7 +17,7 @@ sourceFile:ES5For-of34.ts
 >>>            return { value: o && o[i++], done: !o };
 >>>        }
 >>>    };
->>>    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+>>>    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 >>>};
 >>>var e_1, _a;
 >>>function foo() {

tests/baselines/reference/ES5For-of34.js

@@ -17,7 +17,7 @@ sourceFile:ES5For-of35.ts
 >>>            return { value: o && o[i++], done: !o };
 >>>        }
 >>>    };
->>>    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+>>>    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 >>>};
 >>>var e_1, _a;
 >>>try {

tests/baselines/reference/ES5For-of34.sourcemap.txt

@@ -17,7 +17,7 @@ sourceFile:ES5For-of36.ts
 >>>            return { value: o && o[i++], done: !o };
 >>>        }
 >>>    };
->>>    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+>>>    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 >>>};
 >>>var __read = (this && this.__read) || function (o, n) {
 >>>    var m = typeof Symbol === "function" && o[Symbol.iterator];

tests/baselines/reference/ES5For-of35.js

@@ -26,7 +26,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 var e_1, _a, e_2, _b;
 try {

tests/baselines/reference/ES5For-of35.sourcemap.txt

@@ -43,7 +43,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 function a() {
     var _loop_1, _a, _b, i, e_1_1;

tests/baselines/reference/ES5For-of36.js

@@ -291,7 +291,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 var C4 = /** @class */ (function () {
     function C4() {
@@ -373,7 +373,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 var C5 = /** @class */ (function () {
     function C5() {

tests/baselines/reference/ES5For-of36.sourcemap.txt

@@ -245,7 +245,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 function f4() {
     return __asyncGenerator(this, arguments, function f4_1() {
@@ -322,7 +322,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 function f5() {
     return __asyncGenerator(this, arguments, function f5_1() {

tests/baselines/reference/ES5For-of37.js

@@ -245,7 +245,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 var f4 = function () {
     return __asyncGenerator(this, arguments, function () {
@@ -322,7 +322,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 var f5 = function () {
     return __asyncGenerator(this, arguments, function () {

tests/baselines/reference/blockScopedBindingsInDownlevelGenerator.js

@@ -265,7 +265,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 var o4 = {
     f: function () {
@@ -344,7 +344,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 var o5 = {
     f: function () {

tests/baselines/reference/emitter.asyncGenerators.classMethods.es5.js

@@ -74,7 +74,7 @@ var __values = (this && this.__values) || function(o) {
             return { value: o && o[i++], done: !o };
         }
     };
-    throw new TypeError(s ? "Object not iterable." : "Symbol.iterator is not defined.");
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 (function () {
     var a;