fix(ui): improve layout and scroll behavior in PlanSketch

#331

- Add vertical glue to push content up when there's extra space.
- Ensure content panel takes maximum width but doesn't force height.
- Use a wrapper panel to ensure proper scroll behavior.
- Update toolbar creation to pass target component for proper focus handling.
- Adjust alignment and maximum size for consistent UI rendering.

Author: phodal

core/src/main/kotlin/cc/unitmesh/devti/observer/plan/PlanReviewAction.kt

@@ -32,7 +32,6 @@ class PlanReviewAction : AnAction() {
         val agentStateService = project.getService(AgentStateService::class.java)
 
         val currentPlan = agentStateService.getPlan()
-        val issue = agentStateService.buildOriginIntention() ?: ""
         val plan = MarkdownPlanParser.formatPlanToMarkdown(currentPlan)
 
         val allMessages = agentStateService.getAllMessages()
@@ -44,7 +43,8 @@ class PlanReviewAction : AnAction() {
         val systemPrompt = templateRender.getTemplate("plan-reviewer.vm")
         val history = withoutCodeMsgs.joinToString {
             "# Role ${it.role}\nMessage:\n${it.content}"
-        }
+        } + "\nLastPlan: \n$plan\n"
+
 
         val stream = LlmFactory.create(project).stream(history, systemPrompt)
         AutoDevCoroutineScope.scope(project).launch {
@@ -64,7 +64,7 @@ class PlanReviewAction : AnAction() {
             }
 
             if (plan !== null) {
-                agentStateService.updatePlan(result)
+                agentStateService.updatePlan(plan.text)
             }
         }
     }

core/src/main/kotlin/cc/unitmesh/devti/sketch/ui/plan/PlanSketch.kt

@@ -1,3 +1,4 @@
+// filepath: /Volumes/source/ai/autocrud/core/src/main/kotlin/cc/unitmesh/devti/sketch/ui/plan/PlanSketch.kt
 package cc.unitmesh.devti.sketch.ui.plan
 
 import cc.unitmesh.devti.observer.agent.AgentStateService
@@ -39,6 +40,9 @@ class PlanController(
             contentPanel.add(sectionPanel)
         }
 
+        // Add a vertical glue to push content up when there's extra space
+        contentPanel.add(Box.createVerticalGlue())
+        
         contentPanel.revalidate()
         contentPanel.repaint()
     }
@@ -86,14 +90,17 @@ class PlanSketch(
 ) : JBPanel<PlanSketch>(BorderLayout(JBUI.scale(8), 0)), ExtensionLangSketch {
     private val contentPanel = JPanel().apply {
         layout = BoxLayout(this, BoxLayout.Y_AXIS)
+        // Ensure content panel takes maximum width but doesn't force height
+        maximumSize = Dimension(Int.MAX_VALUE, Int.MAX_VALUE)
+        alignmentX = LEFT_ALIGNMENT
     }
 
     private val toolbarFactory = PlanToolbarFactory(project)
     private val planController = PlanController(project, contentPanel, agentTaskItems)
 
     init {
         if (!isInToolwindow) {
-            add(toolbarFactory.createToolbar(), BorderLayout.NORTH)
+            add(toolbarFactory.createToolbar(this), BorderLayout.NORTH)
             border = JBUI.Borders.empty(8)
         }
 
@@ -103,9 +110,18 @@ class PlanSketch(
             verticalScrollBarPolicy = ScrollPaneConstants.VERTICAL_SCROLLBAR_AS_NEEDED
             horizontalScrollBarPolicy = ScrollPaneConstants.HORIZONTAL_SCROLLBAR_NEVER
             border = null
+            
+            // Make sure viewport tracks width but not height
+            viewport.isOpaque = false
+            viewport.view = contentPanel
         }
 
-        add(scrollPane, BorderLayout.CENTER)
+        // Use a wrapper panel to ensure proper scroll behavior
+        val wrapperPanel = JPanel(BorderLayout())
+        wrapperPanel.add(scrollPane, BorderLayout.CENTER)
+        wrapperPanel.background = JBUI.CurrentTheme.ToolWindow.background()
+        
+        add(wrapperPanel, BorderLayout.CENTER)
 
         minimumSize = Dimension(200, 0)
         background = JBUI.CurrentTheme.ToolWindow.background()
@@ -139,4 +155,3 @@ class PlanSketch(
 
     override fun dispose() {}
 }
-

core/src/main/kotlin/cc/unitmesh/devti/sketch/ui/plan/PlanToolbarFactory.kt

@@ -20,10 +20,12 @@ import javax.swing.JPanel
  * Toolbar factory for creating the plan sketch toolbar
  */
 class PlanToolbarFactory(private val project: Project) {
-    fun createToolbar(): JComponent {
+    fun createToolbar(component: JComponent): JComponent {
         val actionGroup = DefaultActionGroup(createToolbarActions())
         val toolbar = ActionManager.getInstance()
-            .createActionToolbar("PlanSketch", actionGroup, true)
+            .createActionToolbar("PlanSketch", actionGroup, true).apply {
+                this.targetComponent = component
+            }
 
         val titleLabel = JLabel("Thought Plan").apply {
             border = JBUI.Borders.empty(0, 10)

core/src/main/kotlin/cc/unitmesh/devti/sketch/ui/plan/SectionPanel.kt

@@ -1,3 +1,4 @@
+// filepath: /Volumes/source/ai/autocrud/core/src/main/kotlin/cc/unitmesh/devti/sketch/ui/plan/SectionPanel.kt
 package cc.unitmesh.devti.sketch.ui.plan
 
 import cc.unitmesh.devti.AutoDevBundle
@@ -31,14 +32,21 @@ class SectionPanel(
     init {
         layout = BoxLayout(this, BoxLayout.Y_AXIS)
         background = JBUI.CurrentTheme.ToolWindow.background()
+        
+        alignmentX = LEFT_ALIGNMENT
+        maximumSize = Dimension(Int.MAX_VALUE, Int.MAX_VALUE)
+        
         val titlePanel = createSectionTitlePanel()
         add(titlePanel)
 
         planItem.steps.forEach { task ->
-            add(TaskPanel(project, task) {
+            val taskPanel = TaskPanel(project, task) {
                 updateSectionStatus()
                 onStatusChange()
-            })
+            }
+
+            taskPanel.alignmentX = LEFT_ALIGNMENT
+            add(taskPanel)
         }
 
         revalidate()
@@ -94,4 +102,4 @@ class SectionPanel(
     fun updateSectionStatus() {
         planItem.updateCompletionStatus()
     }
-}
+}