refactor(sketch): remove redundant runReadAction calls #257

- Remove unnecessary `runReadAction` calls in `LocalSearchInsCommand` and `SketchToolWindow`.
- Simplify `SketchInputListener` by removing `manualSend` method and inline listener creation.
- Clean up unused imports and redundant

Author: phodal

core/src/main/kotlin/cc/unitmesh/devti/gui/chat/ui/AutoDevInputListener.kt

@@ -12,4 +12,5 @@ interface AutoDevInputListener : EventListener {
     fun editorAdded(editor: EditorEx) {}
     fun onSubmit(component: AutoDevInputSection, trigger: AutoDevInputTrigger) {}
     fun onStop(component: AutoDevInputSection) {}
+    fun manualSend(userInput: String) {}
 }

core/src/main/kotlin/cc/unitmesh/devti/sketch/SketchInputListener.kt

@@ -1,10 +1,6 @@
 package cc.unitmesh.devti.sketch
 
 import cc.unitmesh.devti.AutoDevBundle
-import cc.unitmesh.devti.devin.InsCommand
-import cc.unitmesh.devti.devin.InsCommandListener
-import cc.unitmesh.devti.devin.InsCommandStatus
-import cc.unitmesh.devti.devin.dataprovider.BuiltinCommand
 import cc.unitmesh.devti.gui.chat.ChatCodingService
 import cc.unitmesh.devti.gui.chat.ui.AutoDevInputListener
 import cc.unitmesh.devti.gui.chat.ui.AutoDevInputSection
@@ -18,7 +14,6 @@ import com.intellij.openapi.Disposable
 import com.intellij.openapi.application.ApplicationManager
 import com.intellij.openapi.application.invokeLater
 import com.intellij.openapi.project.Project
-import com.intellij.openapi.vfs.VirtualFile
 import kotlinx.coroutines.flow.cancellable
 import kotlinx.coroutines.launch
 
@@ -52,6 +47,10 @@ class SketchInputListener(
             return
         }
 
+        manualSend(userInput)
+    }
+
+    override fun manualSend(userInput: String) {
         val postProcessors = LanguagePromptProcessor.instance("DevIn").firstOrNull()
         val compiledInput = postProcessors?.compile(project, userInput) ?: userInput
 

core/src/main/kotlin/cc/unitmesh/devti/sketch/SketchToolWindow.kt

@@ -1,6 +1,7 @@
 package cc.unitmesh.devti.sketch
 
 import cc.unitmesh.devti.alignRight
+import cc.unitmesh.devti.devin.dataprovider.BuiltinCommand
 import cc.unitmesh.devti.gui.chat.ChatCodingService
 import cc.unitmesh.devti.gui.chat.message.ChatActionType
 import cc.unitmesh.devti.gui.chat.ui.AutoDevInputSection
@@ -17,6 +18,7 @@ import com.intellij.icons.AllIcons
 import com.intellij.ide.scratch.ScratchRootType
 import com.intellij.openapi.Disposable
 import com.intellij.openapi.application.runInEdt
+import com.intellij.openapi.application.runReadAction
 import com.intellij.openapi.editor.Editor
 import com.intellij.openapi.fileTypes.PlainTextLanguage
 import com.intellij.openapi.project.Project
@@ -78,7 +80,9 @@ class SketchToolWindow(val project: Project, val editor: Editor?, private val sh
         if (showInput) {
             row {
                 checkBox("AI 降临模式（全自动化）").apply {
-                    AutoSketchMode.getInstance(project).isEnable = this.component.isSelected
+                    this.component.addActionListener {
+                        AutoSketchMode.getInstance(project).isEnable = this.component.isSelected
+                    }
                 }
             }
         }
@@ -99,6 +103,8 @@ class SketchToolWindow(val project: Project, val editor: Editor?, private val sh
 
     var handleCancel: ((String) -> Unit)? = null
 
+    private val listener = SketchInputListener(project, chatCodingService, this)
+
     init {
         contentPanel.add(scrollPanel, BorderLayout.CENTER)
         contentPanel.addKeyListener(object : KeyAdapter() {
@@ -118,7 +124,7 @@ class SketchToolWindow(val project: Project, val editor: Editor?, private val sh
                 border = JBUI.Borders.empty(8)
             }
 
-            shireInput.addListener(SketchInputListener(project, chatCodingService, this))
+            shireInput.addListener(listener)
             contentPanel.add(shireInput, BorderLayout.SOUTH)
         }
 
@@ -252,12 +258,25 @@ class SketchToolWindow(val project: Project, val editor: Editor?, private val sh
         val devinCodeFence = codeFenceList.filter { it.language.displayName == "DevIn" }
 
         devinCodeFence.forEach {
+            val commands = setOf(
+                BuiltinCommand.DIR,
+                BuiltinCommand.LOCAL_SEARCH,
+                BuiltinCommand.REV,
+                BuiltinCommand.STRUCTURE,
+                BuiltinCommand.SYMBOL,
+                BuiltinCommand.DATABASE
+            )
+            if (commands.any { command -> it.text.contains("/" + command.commandName + ":") }) {
+                return listener.manualSend(it.text)
+            }
+
             val scratchFile = ScratchRootType.getInstance()
                 .createScratchFile(project, "sketch.shire", it.language, it.text)
                 ?: return
 
-            val psiFile = PsiManager.getInstance(project).findFile(scratchFile)
-                ?: return
+            val psiFile = runReadAction {
+                PsiManager.getInstance(project).findFile(scratchFile)
+            } ?: return
 
             RunService.provider(project, scratchFile)
                 ?.runFile(project, scratchFile, psiFile, isFromToolAction = true)

exts/devins-lang/src/main/kotlin/cc/unitmesh/devti/language/compiler/exec/LocalSearchInsCommand.kt

@@ -4,6 +4,7 @@ import cc.unitmesh.devti.devin.InsCommand
 import cc.unitmesh.devti.devin.dataprovider.BuiltinCommand
 import cc.unitmesh.devti.gui.chat.ui.relativePath
 import cc.unitmesh.devti.language.utils.canBeAdded
+import com.intellij.openapi.application.runReadAction
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.roots.ProjectFileIndex
 import com.intellij.openapi.vfs.VirtualFile
@@ -34,7 +35,7 @@ class LocalSearchInsCommand(val myProject: Project, private val scope: String, v
             throw IllegalArgumentException("Text length should be more than 4")
         }
 
-        val textSearch = search(myProject, text, OVERLAP)
+        val textSearch = runReadAction { search(myProject, text, OVERLAP) }
         return textSearch.map { (file, lines) ->
             val filePath = file.relativePath(myProject)
             val linesWithContext = lines.joinToString("\n")