refactor(devti): introduce FileListViewModel to manage file presentations #358

phodal · phodal · commit 1bb2822fe848 · 2025-04-03T14:53:13.000+08:00
- Create FileListViewModel class to encapsulate file list management logic
- Replace DefaultListModel with FileListViewModel in AutoDevInputSection and InputFileToolbar
- Implement methods in FileListViewModel for adding/removing files and clearing the list
- Add support for recently opened files in FileListViewModel
- Update UI components to interact with FileListViewModel instead of DefaultListModel
diff --git a/core/src/main/kotlin/cc/unitmesh/devti/gui/chat/ui/AutoDevInputSection.kt b/core/src/main/kotlin/cc/unitmesh/devti/gui/chat/ui/AutoDevInputSection.kt
@@ -5,6 +5,7 @@ import cc.unitmesh.devti.AutoDevIcons
 import cc.unitmesh.devti.settings.customize.customizeSetting
 import cc.unitmesh.devti.agent.custom.model.CustomAgentConfig
 import cc.unitmesh.devti.agent.custom.model.CustomAgentState
+import cc.unitmesh.devti.gui.chat.ui.viewmodel.FileListViewModel
 import cc.unitmesh.devti.llms.tokenizer.Tokenizer
 import cc.unitmesh.devti.llms.tokenizer.TokenizerFactory
 import cc.unitmesh.devti.provider.RelatedClassesProvider
@@ -72,8 +73,8 @@ class AutoDevInputSection(private val project: Project, val disposable: Disposab
     private val buttonPanel = JPanel(CardLayout())
     private val inputPanel = BorderLayoutPanel()
 
-    private val listModel = DefaultListModel<FilePresentation>()
-    private val elementsList = JBList(listModel)
+    private val fileListViewModel = FileListViewModel(project)
+    private val elementsList = JBList(fileListViewModel.getListModel())
 
     private val defaultRag: CustomAgentConfig = CustomAgentConfig("<Select Custom Agent>", "Normal")
     private var customRag: ComboBox<CustomAgentConfig> = ComboBox(MutableCollectionComboBoxModel(listOf()))
@@ -173,7 +174,7 @@ class AutoDevInputSection(private val project: Project, val disposable: Disposab
         scrollPane.verticalScrollBarPolicy = JScrollPane.VERTICAL_SCROLLBAR_AS_NEEDED
         scrollPane.horizontalScrollBarPolicy = JScrollPane.HORIZONTAL_SCROLLBAR_AS_NEEDED
 
-        val toolbar = InputFileToolbar.createToolbar(project, this@AutoDevInputSection.listModel)
+        val toolbar = InputFileToolbar.createToolbar(project, fileListViewModel)
 
         val headerPanel = JPanel(BorderLayout())
         headerPanel.add(toolbar, BorderLayout.NORTH)
@@ -199,12 +200,7 @@ class AutoDevInputSection(private val project: Project, val disposable: Disposab
 
         val currentFile = FileEditorManager.getInstance(project).selectedFiles.firstOrNull()
         currentFile?.let {
-            listModel.addIfAbsent(currentFile, first = true)
-            val index = listModel.indexOf(currentFile)
-            if (index != -1) {
-                listModel.remove(index)
-                listModel.insertElementAt(listModel.getElementAt(index), 0)
-            }
+            fileListViewModel.addFileIfAbsent(currentFile, first = true)
         }
     }
 
@@ -215,7 +211,7 @@ class AutoDevInputSection(private val project: Project, val disposable: Disposab
                 override fun selectionChanged(event: FileEditorManagerEvent) {
                     val file = event.newFile ?: return
                     ApplicationManager.getApplication().invokeLater {
-                        listModel.addIfAbsent(file, true)
+                        fileListViewModel.addFileIfAbsent(file, true)
                     }
                 }
             }
@@ -251,20 +247,19 @@ class AutoDevInputSection(private val project: Project, val disposable: Disposab
         val index = list.locationToIndex(e.point)
         if (index == -1) return
 
-        val wrapper = listModel.getElementAt(index)
+        val wrapper = fileListViewModel.getListModel().getElementAt(index)
         val cellBounds = list.getCellBounds(index, index)
         wrapper.panel?.components?.firstOrNull { it.contains(e.x - cellBounds.x - it.x, it.height - 1) }
             ?.let { component ->
                 when {
                     component is JPanel -> {
-                        listModel.removeElement(wrapper)
+                        fileListViewModel.removeFile(wrapper)
                         val vfile = wrapper.virtualFile
                         val relativePath = vfile.path.substringAfter(project.basePath!!).removePrefix("/")
-                        listModel.addIfAbsent(vfile)
+                        fileListViewModel.addFileIfAbsent(vfile)
 
                         input.appendText("\n/" + "file" + ":${relativePath}")
-                        listModel.indexOf(wrapper.virtualFile).takeIf { it != -1 }
-                            ?.let { listModel.remove(it) }
+                        fileListViewModel.removeFileByVirtualFile(wrapper.virtualFile)
 
                         ApplicationManager.getApplication().invokeLater {
                             if (!vfile.isValid) return@invokeLater
@@ -275,17 +270,15 @@ class AutoDevInputSection(private val project: Project, val disposable: Disposab
                         }
                     }
 
-                    component is JLabel && component.icon == AllIcons.Actions.Close -> listModel.removeElement(
-                        wrapper
-                    )
+                    component is JLabel && component.icon == AllIcons.Actions.Close -> fileListViewModel.removeFile(wrapper)
 
                     else -> list.clearSelection()
                 }
             } ?: list.clearSelection()
     }
 
     private fun updateElements(elements: List<PsiElement>?) {
-        elements?.forEach { listModel.addIfAbsent(it.containingFile.virtualFile) }
+        elements?.forEach { fileListViewModel.addFileIfAbsent(it.containingFile.virtualFile) }
     }
 
     fun showStopButton() {
@@ -432,5 +425,3 @@ fun JComponent.mediumFontFunction() {
     }
     putClientProperty(FONT_KEY, f)
 }
-
-
diff --git a/core/src/main/kotlin/cc/unitmesh/devti/gui/chat/ui/InputFileToolbar.kt b/core/src/main/kotlin/cc/unitmesh/devti/gui/chat/ui/InputFileToolbar.kt
@@ -1,18 +1,17 @@
 package cc.unitmesh.devti.gui.chat.ui
 
 import cc.unitmesh.devti.AutoDevBundle
-import com.intellij.openapi.fileEditor.FileEditorManager
+import cc.unitmesh.devti.gui.chat.ui.viewmodel.FileListViewModel
 import com.intellij.openapi.project.Project
 import com.intellij.ui.components.JBLabel
 import com.intellij.ui.components.labels.LinkLabel
 import com.intellij.util.ui.JBUI
 import com.intellij.util.ui.UIUtil
 import javax.swing.Box
-import javax.swing.DefaultListModel
 import javax.swing.JToolBar
 
 object InputFileToolbar {
-    fun createToolbar(project: Project, model: DefaultListModel<FilePresentation>): JToolBar {
+    fun createToolbar(project: Project, viewModel: FileListViewModel): JToolBar {
         val toolbar = JToolBar()
         toolbar.isFloatable = false
 
@@ -24,20 +23,15 @@ object InputFileToolbar {
         toolbar.add(Box.createHorizontalGlue())
 
         val recentFiles = LinkLabel(AutoDevBundle.message("chat.panel.add.openFiles"), null) { _: LinkLabel<Unit>, _: Unit? ->
-            val files = getRecentlyOpenedFiles(project)
-            files.forEach { file ->
-                if (model.elements().asSequence().none { it.virtualFile == file.virtualFile }) {
-                    model.addElement(file)
-                }
-            }
+            viewModel.addRecentlyOpenedFiles()
         }
         
         recentFiles.mediumFontFunction()
         recentFiles.border = JBUI.Borders.emptyRight(10)
         toolbar.add(recentFiles)
 
         val clearAll = LinkLabel(AutoDevBundle.message("chat.panel.clear.all"), null) { _: LinkLabel<Unit>, _: Unit? ->
-            model.removeAllElements()
+            viewModel.clearAllFiles()
         }
 
         clearAll.mediumFontFunction()
@@ -47,17 +41,4 @@ object InputFileToolbar {
 
         return toolbar
     }
-
-    private const val DEFAULT_FILE_LIMIT = 12
-
-    fun getRecentlyOpenedFiles(
-        project: Project,
-        maxFiles: Int = DEFAULT_FILE_LIMIT
-    ): List<FilePresentation> {
-        val fileEditorManager = FileEditorManager.getInstance(project)
-        return fileEditorManager.openFiles
-            .take(maxFiles)
-            .map { FilePresentation.from(project, it) }
-            .toMutableList()
-    }
 }
diff --git a/core/src/main/kotlin/cc/unitmesh/devti/gui/chat/ui/viewmodel/FileListViewModel.kt b/core/src/main/kotlin/cc/unitmesh/devti/gui/chat/ui/viewmodel/FileListViewModel.kt
@@ -0,0 +1,97 @@
+package cc.unitmesh.devti.gui.chat.ui.viewmodel
+
+import cc.unitmesh.devti.gui.chat.ui.FilePresentation
+import cc.unitmesh.devti.util.isInProject
+import com.intellij.diff.editor.DiffVirtualFileBase
+import com.intellij.openapi.Disposable
+import com.intellij.openapi.fileEditor.FileEditorManager
+import com.intellij.openapi.project.Project
+import com.intellij.openapi.vfs.VirtualFile
+import java.util.EventListener
+import javax.swing.DefaultListModel
+
+/**
+ * ViewModel for managing the list of file presentations.
+ */
+class FileListViewModel(private val project: Project) : Disposable {
+    private val listModel = DefaultListModel<FilePresentation>()
+    
+    interface FileListChangeListener : EventListener {
+        fun onFileAdded(file: FilePresentation)
+        fun onFileRemoved(file: FilePresentation)
+        fun onListCleared()
+    }
+    
+    private val listeners = mutableListOf<FileListChangeListener>()
+    
+    fun addChangeListener(listener: FileListChangeListener) {
+        listeners.add(listener)
+    }
+    
+    fun removeChangeListener(listener: FileListChangeListener) {
+        listeners.remove(listener)
+    }
+    
+    fun getListModel(): DefaultListModel<FilePresentation> = listModel
+    
+    fun addFileIfAbsent(vfile: VirtualFile, first: Boolean = false) {
+        if (!vfile.isValid || vfile.fileType.isBinary) return
+        if (!isInProject(vfile, project)) return
+        if (vfile is DiffVirtualFileBase) return
+
+        if (listModel.elements().asSequence().none { it.virtualFile == vfile }) {
+            val filePresentation = FilePresentation(vfile)
+            if (first) {
+                listModel.insertElementAt(filePresentation, 0)
+            } else {
+                listModel.addElement(filePresentation)
+            }
+            
+            listeners.forEach { it.onFileAdded(filePresentation) }
+        }
+    }
+    
+    fun removeFile(file: FilePresentation) {
+        if (listModel.contains(file)) {
+            listModel.removeElement(file)
+            listeners.forEach { it.onFileRemoved(file) }
+        }
+    }
+    
+    fun removeFileByVirtualFile(vfile: VirtualFile) {
+        val filePresentation = listModel.elements().asSequence()
+            .find { it.virtualFile == vfile }
+        
+        filePresentation?.let {
+            listModel.removeElement(it)
+            listeners.forEach { listener -> listener.onFileRemoved(it) }
+        }
+    }
+    
+    fun clearAllFiles() {
+        listModel.removeAllElements()
+        listeners.forEach { it.onListCleared() }
+    }
+    
+    fun getRecentlyOpenedFiles(maxFiles: Int = 12): List<FilePresentation> {
+        val fileEditorManager = FileEditorManager.getInstance(project)
+        return fileEditorManager.openFiles
+            .take(maxFiles)
+            .map { FilePresentation.from(project, it) }
+            .toMutableList()
+    }
+    
+    fun addRecentlyOpenedFiles() {
+        val files = getRecentlyOpenedFiles()
+        files.forEach { file ->
+            if (listModel.elements().asSequence().none { it.virtualFile == file.virtualFile }) {
+                listModel.addElement(file)
+                listeners.forEach { it.onFileAdded(file) }
+            }
+        }
+    }
+    
+    override fun dispose() {
+        listeners.clear()
+    }
+}
