fix(devins-language): use List instead of Iterable for lookup result #101

Changed return type in JavaCustomDevInsSymbolProvider and DevInsSymbolProvider functions from Iterable to List to improve type safety and readability. Updated execute function in SymbolInsCommand to return String instead of nullable.

Author: phodal

exts/devins-lang/src/main/kotlin/cc/unitmesh/devti/language/compiler/DevInsCompiler.kt

@@ -196,9 +196,11 @@ class DevInsCompiler(private val myProject: Project, val file: DevInFile, val ed
 
 class SymbolInsCommand(val myProject: Project, val prop: String) :
     InsCommand {
-    override fun execute(): String? {
-        val result = DevInsSymbolProvider.all().map {
-            it.resolveSymbol(myProject, prop).joinToString("\n")
+    override fun execute(): String {
+        val result = DevInsSymbolProvider.all().mapNotNull {
+            val found = it.resolveSymbol(myProject, prop)
+            if (found.isEmpty()) return@mapNotNull null
+            "```${it.language}\n${found.joinToString("\n")}\n```\n"
         }
 
         if (result.isEmpty()) {

java/src/main/kotlin/cc/unitmesh/idea/provider/JavaCustomDevInsSymbolProvider.kt

@@ -25,7 +25,7 @@ class JavaCustomDevInsSymbolProvider : DevInsSymbolProvider {
         project: Project,
         parameters: CompletionParameters,
         result: CompletionResultSet,
-    ): Iterable<LookupElement> {
+    ): List<LookupElement> {
         val lookupElements: MutableList<LookupElement> = SmartList()
         val searchScope = ProjectScope.getProjectScope(project)
         val javaFiles = FileTypeIndex.getFiles(JavaFileType.INSTANCE, searchScope)
@@ -51,7 +51,7 @@ class JavaCustomDevInsSymbolProvider : DevInsSymbolProvider {
         return lookupElements
     }
 
-    override fun resolveSymbol(project: Project, symbol: String): Iterable<String> {
+    override fun resolveSymbol(project: Project, symbol: String): List<String> {
         val scope = GlobalSearchScope.allScope(project)
 
         if (symbol.isEmpty()) return emptyList()

src/main/kotlin/cc/unitmesh/devti/provider/devins/DevInsSymbolProvider.kt

@@ -22,7 +22,7 @@ interface DevInsSymbolProvider {
         project: Project,
         parameters: CompletionParameters,
         result: CompletionResultSet
-    ): Iterable<LookupElement>
+    ): List<LookupElement>
 
     /**
      * Resolves the symbol for different programming languages.
@@ -33,7 +33,7 @@ interface DevInsSymbolProvider {
      *
      * Format: `java.lang.String#length`, means: `<package>.<class>#<method>`
      */
-    fun resolveSymbol(project: Project, symbol: String): Iterable<String>
+    fun resolveSymbol(project: Project, symbol: String): List<String>
 
     companion object {
         private val EP_NAME: ExtensionPointName<DevInsSymbolProvider> =