Skip to content

Commit 29480d5

Browse files
committed
feat(devin-lang): add fullWidth utility function to AutoDevSettingsEditor.kt and remove unused imports from DevInProgramRunner.kt #101
The AutoDevSettingsEditor now includes a fullWidth utility function to ensure the script selector text field spans the entire width of its container, improving usability. Additionally, unnecessary imports have been removed from DevInProgramRunner.kt to streamline the codebase and adhere to best practices.
1 parent b8c0bc2 commit 29480d5

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed
Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package cc.unitmesh.devti.language.run
22

33
import cc.unitmesh.devti.AutoDevBundle
4+
import cc.unitmesh.devti.fullWidth
45
import com.intellij.openapi.fileChooser.FileChooserDescriptorFactory
56
import com.intellij.openapi.options.SettingsEditor
67
import com.intellij.openapi.project.Project
@@ -9,22 +10,28 @@ import com.intellij.ui.dsl.builder.panel
910
import javax.swing.JComponent
1011

1112
class AutoDevSettingsEditor(val project: Project) : SettingsEditor<AutoDevConfiguration>() {
12-
private val myScriptSelector: TextFieldWithBrowseButton? = null
13+
private val myScriptSelector: TextFieldWithBrowseButton = TextFieldWithBrowseButton()
1314

14-
override fun createEditor(): JComponent = panel {
15-
myScriptSelector?.addBrowseFolderListener(
15+
init {
16+
myScriptSelector.addBrowseFolderListener(
1617
AutoDevBundle.message("devin.label.choose.file"),
1718
"",
1819
project,
1920
FileChooserDescriptorFactory.createSingleFileDescriptor()
2021
)
2122
}
2223

24+
override fun createEditor(): JComponent = panel {
25+
row {
26+
cell(myScriptSelector).fullWidth()
27+
}
28+
}
29+
2330
override fun resetEditorFrom(configuration: AutoDevConfiguration) {
24-
myScriptSelector!!.text = configuration.getScriptPath()
31+
myScriptSelector.text = configuration.getScriptPath()
2532
}
2633

2734
override fun applyEditorTo(configuration: AutoDevConfiguration) {
28-
configuration.setScriptPath(myScriptSelector!!.text)
35+
configuration.setScriptPath(myScriptSelector.text)
2936
}
3037
}

exts/devin-lang/src/main/kotlin/cc/unitmesh/devti/language/run/DevInProgramRunner.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,21 @@
11
package cc.unitmesh.devti.language.run
22

3-
import cc.unitmesh.devti.runconfig.AutoDevCommandRunner
43
import com.intellij.execution.ExecutionManager
54
import com.intellij.execution.configurations.RunProfile
65
import com.intellij.execution.configurations.RunProfileState
76
import com.intellij.execution.configurations.RunnerSettings
87
import com.intellij.execution.runners.ExecutionEnvironment
98
import com.intellij.execution.runners.ProgramRunner
109
import com.intellij.execution.runners.showRunContent
11-
import com.intellij.openapi.diagnostic.Logger
12-
import com.intellij.openapi.diagnostic.logger
1310
import com.intellij.openapi.fileEditor.FileDocumentManager
1411
import org.jetbrains.annotations.NonNls
1512

1613
class DevInProgramRunner : ProgramRunner<RunnerSettings> {
1714
companion object {
18-
private val log: Logger = logger<DevInProgramRunner>()
1915
const val RUNNER_ID: String = "DevInCommandRunner"
2016
}
2117

22-
override fun getRunnerId(): @NonNls String = AutoDevCommandRunner.RUNNER_ID
18+
override fun getRunnerId(): @NonNls String = RUNNER_ID
2319

2420
override fun canRun(executorId: String, profile: RunProfile): Boolean {
2521
return profile is AutoDevConfiguration

0 commit comments

Comments
 (0)