refactor(core): conditionally notify on non-empty reasoner output #271

phodal · phodal · commit 2dfcc582d311 · 2025-02-27T13:37:02.000+08:00
Prevent unnecessary notifications by ensuring `AutoDevNotifications.notify` is only called when `reasonerOutput` is not empty.
diff --git a/core/src/main/kotlin/cc/unitmesh/devti/llms/custom/CustomSSEProcessor.kt b/core/src/main/kotlin/cc/unitmesh/devti/llms/custom/CustomSSEProcessor.kt
@@ -147,7 +147,9 @@ open class CustomSSEProcessor(private val project: Project) {
 
                     if (output.isNotEmpty()) {
                         messages += Message(ChatRole.Assistant.roleName(), output)
-                        AutoDevNotifications.notify(project, reasonerOutput)
+                        if (reasonerOutput.isNotEmpty()) {
+                            AutoDevNotifications.notify(project, reasonerOutput)
+                        }
                     }
 
                     recording.write(RecordingInstruction(promptText, output))

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,9 @@ open class CustomSSEProcessor(private val project: Project) {`
`147`	`147`
`148`	`148`	`if (output.isNotEmpty()) {`
`149`	`149`	`messages += Message(ChatRole.Assistant.roleName(), output)`
`150`		`- AutoDevNotifications.notify(project, reasonerOutput)`
	`150`	`+ if (reasonerOutput.isNotEmpty()) {`
	`151`	`+ AutoDevNotifications.notify(project, reasonerOutput)`
	`152`	`+ }`
`151`	`153`	`}`
`152`	`154`
`153`	`155`	`recording.write(RecordingInstruction(promptText, output))`