feat(lint): add UI for displaying lint inspection errors #288

- Introduced a new `PsiErrorUI` object to handle the display of lint inspection errors in a table format.
- Updated `PsiErrorCollector` to return `SketchInspectionError` objects instead of plain strings.
- Integrated `PsiErrorUI` into `SingleFileDiffSketch` to

Author: phodal

core/src/main/kotlin/cc/unitmesh/devti/sketch/lint/PsiErrorCollector.kt

@@ -7,6 +7,7 @@ import com.intellij.codeInsight.daemon.impl.DaemonProgressIndicator
 import com.intellij.codeInspection.InspectionEngine
 import com.intellij.codeInspection.InspectionManager
 import com.intellij.codeInspection.ProblemDescriptor
+import com.intellij.codeInspection.ProblemHighlightType
 import com.intellij.codeInspection.ex.GlobalInspectionContextBase
 import com.intellij.codeInspection.ex.LocalInspectionToolWrapper
 import com.intellij.codeInspection.util.InspectionMessage
@@ -16,6 +17,8 @@ import com.intellij.openapi.application.runReadAction
 import com.intellij.openapi.editor.Document
 import com.intellij.openapi.fileEditor.FileDocumentManager
 import com.intellij.openapi.project.Project
+import com.intellij.openapi.ui.popup.JBPopup
+import com.intellij.openapi.ui.popup.JBPopupFactory
 import com.intellij.openapi.util.Disposer
 import com.intellij.openapi.util.TextRange
 import com.intellij.openapi.vfs.VirtualFile
@@ -24,13 +27,85 @@ import com.intellij.psi.PsiElement
 import com.intellij.psi.PsiErrorElement
 import com.intellij.psi.PsiFile
 import com.intellij.psi.PsiManager
+import com.intellij.ui.components.JBLabel
+import com.intellij.ui.components.JBScrollPane
+import com.intellij.ui.table.JBTable
 import com.intellij.util.PairProcessor
 import com.intellij.util.messages.MessageBusConnection
+import java.awt.Dimension
+import java.awt.event.MouseAdapter
+import java.awt.event.MouseEvent
 import java.util.concurrent.CompletableFuture
 import java.util.concurrent.TimeUnit
+import javax.swing.BorderFactory
+import javax.swing.JPanel
+import javax.swing.JTable
+import javax.swing.table.DefaultTableModel
+
+data class SketchInspectionError(
+    val lineNumber: Int,
+    val description: String,
+    val highlightType: ProblemHighlightType,
+) {
+    companion object {
+        fun from(problemDescriptor: ProblemDescriptor): SketchInspectionError {
+            return SketchInspectionError(
+                problemDescriptor.lineNumber,
+                problemDescriptor.descriptionTemplate,
+                problemDescriptor.highlightType
+            )
+        }
+    }
+}
+
+object PsiErrorUI {
+    fun showErrors(errors: List<SketchInspectionError>, panel: JPanel) {
+        val columnNames = arrayOf("Line", "Description", "Highlight Type")
+        val data = errors.map {
+            arrayOf(it.lineNumber, it.description, it.highlightType.toString())
+        }.toTypedArray()
+
+        val tableModel = DefaultTableModel(data, columnNames)
+
+        val table = JBTable(tableModel).apply {
+            autoResizeMode = JTable.AUTO_RESIZE_ALL_COLUMNS
+        }
+
+        val scrollPane = JBScrollPane(table).apply {
+            preferredSize = Dimension(600, 300)
+        }
+        val errorLabel = JBLabel("Found Lint issue: ${errors.size}").apply {
+            border = BorderFactory.createEmptyBorder(5, 5, 5, 5)
+        }
+        errorLabel.addMouseListener(object : MouseAdapter() {
+            override fun mouseClicked(e: MouseEvent?) {
+                createErrorButton(scrollPane, table, errors).showInCenterOf(panel)
+            }
+
+            // hover also show tip
+            override fun mouseEntered(e: MouseEvent) {
+                errorLabel.toolTipText = "Click to view all errors"
+            }
+        })
+
+        panel.add(errorLabel)
+    }
+
+    private fun createErrorButton(
+        scrollPane: JBScrollPane,
+        table: JBTable,
+        errors: List<SketchInspectionError>
+    ): JBPopup = JBPopupFactory.getInstance()
+        .createComponentPopupBuilder(scrollPane, table)
+        .setTitle("Found Lint Issues: ${errors.size}")
+        .setResizable(true)
+        .setMovable(true)
+        .setRequestFocus(true)
+        .createPopup()
+}
 
 object PsiErrorCollector {
-    fun runInspections(project: Project, psiFile: PsiFile, originFile: VirtualFile): List<@InspectionMessage String> {
+    fun runInspections(project: Project, psiFile: PsiFile, originFile: VirtualFile): List<SketchInspectionError> {
         val globalContext = InspectionManager.getInstance(project).createNewGlobalContext()
                 as? GlobalInspectionContextBase ?: return emptyList()
 
@@ -54,12 +129,11 @@ object PsiErrorCollector {
 
             val problems = result.values.flatten()
             return@runReadAction problems.sortedBy { it.lineNumber }.distinctBy { it.lineNumber }.map {
-                "Line ${it.lineNumber + 1}: ${it.descriptionTemplate}"
+                SketchInspectionError.from(it)
             }
         }
     }
 
-    //  skip NpmUsedModulesInstalled, ProblematicWhitespace, JSXUnresolvedComponent, UnterminatedStatement, UnterminatedStatementJS
     private val frontEndSkipError =
         setOf(
             "NpmUsedModulesInstalled",
@@ -76,9 +150,11 @@ object PsiErrorCollector {
     ): MutableList<LocalInspectionToolWrapper> {
         val inspectionProfile = InspectionProjectProfileManager.getInstance(project).currentProfile
         val toolWrappers = inspectionProfile.getInspectionTools(psiFile)
-            .filter { it.isApplicable(psiFile.language) }
-            .filter { it.shortName !in frontEndSkipError }
-            .filter { it.defaultLevel.severity == HighlightSeverity.WARNING || it.defaultLevel.severity == HighlightSeverity.ERROR }
+            .filter {
+                it.isApplicable(psiFile.language)
+                        && it.displayKey?.id !in frontEndSkipError
+                        && it.defaultLevel.severity == HighlightSeverity.WARNING || it.defaultLevel.severity == HighlightSeverity.ERROR
+            }
 
         toolWrappers.forEach {
             it.initialize(globalContext)

core/src/main/kotlin/cc/unitmesh/devti/sketch/ui/patch/SingleFileDiffSketch.kt

@@ -2,6 +2,7 @@ package cc.unitmesh.devti.sketch.ui.patch
 
 import cc.unitmesh.devti.AutoDevBundle
 import cc.unitmesh.devti.sketch.lint.PsiErrorCollector
+import cc.unitmesh.devti.sketch.lint.PsiErrorUI
 import cc.unitmesh.devti.sketch.ui.LangSketch
 import cc.unitmesh.devti.template.context.TemplateContext
 import com.intellij.diff.editor.DiffVirtualFileBase
@@ -214,33 +215,14 @@ class SingleFileDiffSketch(
 
     fun lintCheckForNewCode(currentFile: VirtualFile) {
         if (newCode.isEmpty()) return
-
         val newFile = LightVirtualFile(currentFile, newCode, LocalTimeCounter.currentTime())
         val psiFile = runReadAction { PsiManager.getInstance(myProject).findFile(newFile) } ?: return
-        val runInspections = PsiErrorCollector.runInspections(myProject, psiFile, currentFile)
-        if (runInspections.isNotEmpty()) {
-            showErrors(runInspections)
+        val errors = PsiErrorCollector.runInspections(myProject, psiFile, currentFile)
+        if (errors.isNotEmpty()) {
+            PsiErrorUI.showErrors(errors, this@SingleFileDiffSketch.mainPanel)
         }
     }
 
-    private fun showErrors(errors: List<String>) {
-        val errorPanel = JPanel(VerticalLayout(5)).apply {
-            val errorLabel = JBLabel("Found Lint issue: ${errors.size}").apply {
-                border = BorderFactory.createEmptyBorder(5, 5, 5, 5)
-            }
-            add(errorLabel)
-
-            errors.forEach { error ->
-                val errorLabel = JBLabel(error).apply {
-                    border = BorderFactory.createEmptyBorder(5, 5, 5, 5)
-                }
-                add(errorLabel)
-            }
-        }
-
-        mainPanel.add(errorPanel)
-    }
-
     override fun dispose() {}
 }