refactor(observer): consolidate error notification logic #259

- Move error notification logic to `AgentObserver` for reusability.
- Replace direct chat window calls with `sendErrorNotification` method.
- Simplify process output handling in `ExternalTaskAgentObserver`.

Author: phodal

core/src/main/kotlin/cc/unitmesh/devti/observer/ExternalTaskAgentObserver.kt

@@ -1,7 +1,6 @@
 package cc.unitmesh.devti.observer
 
 import cc.unitmesh.devti.provider.observer.AgentObserver
-import com.intellij.application.subscribe
 import com.intellij.execution.ExecutionListener
 import com.intellij.execution.ExecutionManager
 import com.intellij.execution.process.CapturingProcessHandler
@@ -20,28 +19,37 @@ class ExternalTaskAgentObserver : AgentObserver, Disposable {
     private var connection: MessageBusConnection? = null
 
     override fun onRegister(project: Project) {
-        ExecutionManager.EXECUTION_TOPIC.subscribe(this, object : ExecutionListener {
+        connection = project.messageBus.connect()
+        connection?.subscribe(ExecutionManager.EXECUTION_TOPIC, object : ExecutionListener {
+            private var globalBuffer = StringBuilder()
+
             override fun processStarted(executorId: String, env: ExecutionEnvironment, handler: ProcessHandler) {
                 if (handler is ExternalSystemProcessHandler) {
                     handler.addProcessListener(object : ProcessListener {
                         private val outputBuffer = StringBuilder()
-
-                        override fun onTextAvailable(event: ProcessEvent,
+                        override fun onTextAvailable(
+                            event: ProcessEvent,
                             outputType: Key<*>
                         ) {
                             outputBuffer.append(event.text)
                         }
 
                         override fun processTerminated(event: ProcessEvent) {
-                            println("Process Output:\n$outputBuffer")
+                            globalBuffer = outputBuffer
                         }
                     })
                 }
             }
 
-            override fun processTerminated(executorId: String, env: ExecutionEnvironment, handler: ProcessHandler, exitCode: Int) {
-                if (handler is ExternalSystemProcessHandler) {
-                    println("Process terminated with exit code $exitCode")
+            override fun processTerminated(
+                executorId: String,
+                env: ExecutionEnvironment,
+                handler: ProcessHandler,
+                exitCode: Int
+            ) {
+                if (handler is ExternalSystemProcessHandler && exitCode != 0) {
+                    val prompt = "Help Me fix follow build issue:\n$globalBuffer"
+                    sendErrorNotification(project, prompt)
                 }
             }
         })

core/src/main/kotlin/cc/unitmesh/devti/observer/TestAgentObserver.kt

@@ -29,13 +29,11 @@ class TestAgentObserver : AgentObserver, Disposable {
     private fun sendResult(test: SMTestProxy, project: Project, searchScope: GlobalSearchScope) {
         val sourceCode = test.getLocation(project, searchScope)
         runInEdt {
-            sendToChatWindow(project, ChatActionType.CHAT) { contentPanel, _ ->
-                val psiElement = sourceCode?.psiElement
-                val language = psiElement?.language?.displayName ?: ""
-                val filepath = psiElement?.containingFile?.virtualFile?.relativePath(project) ?: ""
-                val code = runReadAction<String> { psiElement?.text ?: "" }
-                contentPanel.setInput(
-                    """Help me fix follow test issue:
+            val psiElement = sourceCode?.psiElement
+            val language = psiElement?.language?.displayName ?: ""
+            val filepath = psiElement?.containingFile?.virtualFile?.relativePath(project) ?: ""
+            val code = runReadAction<String> { psiElement?.text ?: "" }
+            val prompt = """Help me fix follow test issue:
                                | ErrorMessage:
                                |```
                                |${test.errorMessage}
@@ -49,8 +47,9 @@ class TestAgentObserver : AgentObserver, Disposable {
                                |$code
                                |```
                                |""".trimMargin()
-                )
-            }
+
+
+            sendErrorNotification(project, prompt)
         }
     }
 

core/src/main/kotlin/cc/unitmesh/devti/provider/observer/AgentObserver.kt

@@ -1,11 +1,19 @@
 package cc.unitmesh.devti.provider.observer
 
+import cc.unitmesh.devti.gui.chat.message.ChatActionType
+import cc.unitmesh.devti.gui.sendToChatWindow
 import com.intellij.openapi.extensions.ExtensionPointName
 import com.intellij.openapi.project.Project
 
 interface AgentObserver {
     fun onRegister(project: Project)
 
+    fun sendErrorNotification(project: Project, prompt: String) {
+        sendToChatWindow(project, ChatActionType.CHAT) { contentPanel, _ ->
+            contentPanel.setInput(prompt)
+        }
+    }
+
     companion object {
         private val EP_NAME: ExtensionPointName<AgentObserver> =
             ExtensionPointName("cc.unitmesh.agentObserver")