refactor(lint): simplify error collection and add inspections #288

- Replace `collectSyntaxError` with `runInspections` for better error handling.
- Remove unnecessary parameters and streamline error collection logic.
- Add `showErrors` method to display lint issues in the UI.

Author: phodal

core/src/main/kotlin/cc/unitmesh/devti/sketch/lint/PsiErrorCollector.kt

@@ -1,19 +1,19 @@
 package cc.unitmesh.devti.sketch.lint
 
+import com.intellij.analysis.AnalysisScope
 import com.intellij.codeInsight.daemon.DaemonCodeAnalyzer
 import com.intellij.codeInsight.daemon.impl.DaemonCodeAnalyzerEx
-import com.intellij.codeInsight.daemon.impl.DaemonCodeAnalyzerImpl
+import com.intellij.codeInspection.InspectionManager
+import com.intellij.codeInspection.ex.GlobalInspectionContextBase
 import com.intellij.lang.annotation.HighlightSeverity
 import com.intellij.openapi.Disposable
 import com.intellij.openapi.application.runReadAction
 import com.intellij.openapi.editor.Document
 import com.intellij.openapi.fileEditor.FileDocumentManager
-import com.intellij.openapi.fileEditor.FileEditorManager
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.util.Disposer
 import com.intellij.openapi.util.TextRange
 import com.intellij.openapi.vfs.VirtualFile
-import com.intellij.psi.PsiDocumentManager
 import com.intellij.psi.PsiElement
 import com.intellij.psi.PsiErrorElement
 import com.intellij.psi.PsiFile
@@ -22,16 +22,12 @@ import java.util.concurrent.CompletableFuture
 import java.util.concurrent.TimeUnit
 
 object PsiErrorCollector {
-    fun collectSyntaxError(
-        psiFile: PsiFile,
-        project: Project,
-    ): List<String> {
-        var errors: List<String> = listOf()
-        collectSyntaxError(psiFile, psiFile.virtualFile, project) {
-            errors = it
-        }
+    fun runInspections(project: Project, psiFile: PsiFile) {
+        val scope = AnalysisScope(psiFile)
+        val globalContext = InspectionManager.getInstance(project).createNewGlobalContext() as? GlobalInspectionContextBase
 
-        return errors
+        globalContext?.currentScope = scope
+        globalContext?.doInspections(scope)
     }
 
     /**
@@ -40,12 +36,10 @@ object PsiErrorCollector {
      *
      * @param sourceFile The PSI file from which syntax errors need to be collected.
      * @param runAction A callback function that takes a list of errors as input and performs some action.
-     * @param outputFile The virtual file where the errors will be collected.
      * @param project The project to which the files belong.
      */
     fun collectSyntaxError(
         sourceFile: PsiFile,
-        outputFile: VirtualFile,
         project: Project,
         runAction: ((errors: List<String>) -> Unit)?,
     ) {
@@ -54,15 +48,11 @@ object PsiErrorCollector {
             return runAction?.invoke(collectPsiError) ?: Unit
         }
 
-        val document = runReadAction { FileDocumentManager.getInstance().getDocument(outputFile) } ?: return
+        val document = runReadAction { FileDocumentManager.getInstance().getDocument(sourceFile.virtualFile) } ?: return
 
         val range = TextRange(0, document.textLength)
         val errors = mutableListOf<String>()
 
-        runReadAction {
-            DaemonCodeAnalyzerEx.getInstanceEx(project).restart(sourceFile)
-        }
-
         val hintDisposable = Disposer.newDisposable()
         val busConnection: MessageBusConnection = project.messageBus.connect(hintDisposable)
         val future: CompletableFuture<List<String>> = CompletableFuture()
@@ -72,6 +62,10 @@ object PsiErrorCollector {
             }
         )
 
+        runReadAction {
+            DaemonCodeAnalyzerEx.getInstanceEx(project).restart(sourceFile)
+        }
+
         future.get(30, TimeUnit.SECONDS)
     }
 

core/src/main/kotlin/cc/unitmesh/devti/sketch/ui/patch/SingleFileDiffSketch.kt

@@ -133,7 +133,6 @@ class SingleFileDiffSketch(
         mainPanel.add(myHeaderPanel)
         mainPanel.add(contentPanel)
 
-        // runin thread
         ApplicationManager.getApplication().executeOnPooledThread {
             lintCheckForNewCode()
         }
@@ -228,11 +227,14 @@ class SingleFileDiffSketch(
 
         val newFile = LightVirtualFile(currentFile.name, newCode)
         val psiFile = runReadAction { PsiManager.getInstance(myProject).findFile(newFile) } ?: return
-        val errors = PsiErrorCollector.collectSyntaxError(psiFile, myProject)
-
-        if (errors.isEmpty()) return
+        PsiErrorCollector.collectSyntaxError(psiFile, myProject) { errors ->
+            PsiErrorCollector.runInspections(myProject, psiFile)
+            if (errors.isEmpty()) return@collectSyntaxError
+            showErrors(errors)
+        }
+    }
 
-        // show error size and hover to show error message
+    private fun showErrors(errors: List<String>) {
         val errorPanel = JPanel(VerticalLayout(5)).apply {
             val errorLabel = JBLabel("Found Lint issue: ${errors.size}").apply {
                 border = BorderFactory.createEmptyBorder(5, 5, 5, 5)