refactor(devti): refactor file action handling in AutoDevInputSection #358

- Extract file action logic into FileListViewModel
- Implement handleFileAction and determineFileAction methods
- Simplify file action handling in AutoDevInputSection- Improve code readability and maintainability

Author: phodal

core/src/main/kotlin/cc/unitmesh/devti/gui/chat/ui/AutoDevInputSection.kt

@@ -246,32 +246,23 @@ class AutoDevInputSection(private val project: Project, val disposable: Disposab
 
         val wrapper = fileListViewModel.getListModel().getElementAt(index)
         val cellBounds = list.getCellBounds(index, index)
-        wrapper.panel?.components?.firstOrNull { it.contains(e.x - cellBounds.x - it.x, it.height - 1) }
-            ?.let { component ->
-                when {
-                    component is JPanel -> {
-                        fileListViewModel.removeFile(wrapper)
-                        val vfile = wrapper.virtualFile
-                        val relativePath = vfile.path.substringAfter(project.basePath!!).removePrefix("/")
-                        fileListViewModel.addFileIfAbsent(vfile)
-
-                        input.appendText("\n/" + "file" + ":${relativePath}")
-                        fileListViewModel.removeFileByVirtualFile(wrapper.virtualFile)
-
-                        ApplicationManager.getApplication().invokeLater {
-                            if (!vfile.isValid) return@invokeLater
-                            val psiFile = PsiManager.getInstance(project).findFile(vfile) ?: return@invokeLater
-                            val relatedElements =
-                                RelatedClassesProvider.provide(psiFile.language)?.lookupIO(psiFile)
-                            updateElements(relatedElements)
-                        }
-                    }
-
-                    component is JLabel && component.icon == AllIcons.Actions.Close -> fileListViewModel.removeFile(wrapper)
-
-                    else -> list.clearSelection()
+        
+        val actionType = fileListViewModel.determineFileAction(wrapper, e.point, cellBounds)
+        val actionPerformed = fileListViewModel.handleFileAction(wrapper, actionType) { vfile, relativePath ->
+            if (relativePath != null) {
+                input.appendText("\n/" + "file" + ":${relativePath}")
+                ApplicationManager.getApplication().invokeLater {
+                    if (!vfile.isValid) return@invokeLater
+                    val psiFile = PsiManager.getInstance(project).findFile(vfile) ?: return@invokeLater
+                    val relatedElements = RelatedClassesProvider.provide(psiFile.language)?.lookupIO(psiFile)
+                    updateElements(relatedElements)
                 }
-            } ?: list.clearSelection()
+            }
+        }
+
+        if (!actionPerformed) {
+            list.clearSelection()
+        }
     }
 
     private fun updateElements(elements: List<PsiElement>?) {
@@ -405,3 +396,4 @@ fun JComponent.mediumFontFunction() {
     }
     putClientProperty(FONT_KEY, f)
 }
+

core/src/main/kotlin/cc/unitmesh/devti/gui/chat/ui/viewmodel/FileListViewModel.kt

@@ -9,6 +9,7 @@ import com.intellij.openapi.project.Project
 import com.intellij.openapi.vfs.VirtualFile
 import java.util.EventListener
 import javax.swing.DefaultListModel
+import java.awt.Point
 
 /**
  * ViewModel for managing the list of file presentations.
@@ -22,6 +23,12 @@ class FileListViewModel(private val project: Project) : Disposable {
         fun onListCleared()
     }
 
+    enum class FileActionType {
+        INSERT,
+        REMOVE,
+        NONE
+    }
+    
     private val listeners = mutableListOf<FileListChangeListener>()
 
     fun addChangeListener(listener: FileListChangeListener) {
@@ -91,6 +98,73 @@ class FileListViewModel(private val project: Project) : Disposable {
         }
     }
 
+    /**
+     * Handles file operations based on the action type.
+     * 
+     * @param filePresentation The file presentation to operate on
+     * @param actionType The type of action to perform
+     * @param callback Callback to handle UI-specific operations
+     * @return True if an action was performed, false otherwise
+     */
+    fun handleFileAction(filePresentation: FilePresentation,
+                         actionType: FileActionType,
+                         callback: (VirtualFile, String?) -> Unit): Boolean {
+        when (actionType) {
+            FileActionType.INSERT -> {
+                val vfile = filePresentation.virtualFile
+                if (!vfile.isValid) return false
+                
+                // Get relative path for display
+                val relativePath = try {
+                    project.basePath?.let { basePath ->
+                        vfile.path.substringAfter(basePath).removePrefix("/")
+                    } ?: vfile.path
+                } catch (e: Exception) {
+                    vfile.path
+                }
+                
+                // Remove and re-add to prioritize
+                removeFile(filePresentation)
+                addFileIfAbsent(vfile)
+                
+                // Call back to UI with file and path
+                callback(vfile, relativePath)
+                
+                // Remove from list after processing
+                removeFileByVirtualFile(vfile)
+                return true
+            }
+            FileActionType.REMOVE -> {
+                removeFile(filePresentation)
+                return true
+            }
+            FileActionType.NONE -> return false
+        }
+    }
+    
+    /**
+     * Determines the appropriate action for a file based on component coordinates.
+     * 
+     * @param filePresentation The file presentation
+     * @param componentPoint The local point in the component
+     * @param componentBounds The bounds of the component cell
+     * @return The appropriate action type
+     */
+    fun determineFileAction(filePresentation: FilePresentation, componentPoint: Point, 
+                            componentBounds: java.awt.Rectangle): FileActionType {
+        // Extract component hit detection logic
+        val hitComponent = filePresentation.panel?.components?.firstOrNull { 
+            it.contains(componentPoint.x - componentBounds.x - it.x, it.height - 1) 
+        }
+        
+        return when {
+            hitComponent is javax.swing.JPanel -> FileActionType.INSERT
+            hitComponent is javax.swing.JLabel && 
+                hitComponent.icon == com.intellij.icons.AllIcons.Actions.Close -> FileActionType.REMOVE
+            else -> FileActionType.NONE
+        }
+    }
+    
     override fun dispose() {
         listeners.clear()
     }