Skip to content

Commit 9dd5c48

Browse files
committed
feat(devins-cpp): refactor for factory usage #100
1 parent 23865dd commit 9dd5c48

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

cpp/src/main/kotlin/cc/unitmesh/cpp/provider/testing/CppAutoTestService.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import com.intellij.openapi.project.guessProjectDir
1212
import com.intellij.openapi.vfs.VirtualFile
1313
import com.intellij.psi.PsiElement
1414
import com.intellij.psi.PsiFile
15+
import com.jetbrains.cidr.cpp.execution.testing.tcatch.CMakeCatchTestRunConfigurationType
1516
import com.jetbrains.cidr.lang.OCLanguage
1617
import com.jetbrains.cidr.lang.psi.OCFunctionDeclaration
1718
import java.io.File
@@ -32,7 +33,8 @@ class CppAutoTestService : AutoTestService() {
3233
return null
3334
}
3435

35-
val settings = CppTestConfiguration.createConfiguration(project, virtualFile).firstOrNull()
36+
val factory = CMakeCatchTestRunConfigurationType.getInstance().factory
37+
val settings = CppTestConfiguration.createConfiguration(project, virtualFile, factory).firstOrNull()
3638
return settings?.configuration
3739
}
3840

cpp/src/main/kotlin/cc/unitmesh/cpp/provider/testing/CppTestConfiguration.kt

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,14 @@ import com.intellij.openapi.vfs.VirtualFile
99
import com.jetbrains.cidr.cpp.cmake.model.CMakeTarget
1010
import com.jetbrains.cidr.cpp.cmake.workspace.CMakeWorkspace
1111
import com.jetbrains.cidr.cpp.execution.testing.CMakeTestRunConfiguration
12-
import com.jetbrains.cidr.cpp.execution.testing.tcatch.CMakeCatchTestRunConfigurationType
1312
import com.jetbrains.cidr.execution.ExecutableData
1413
import com.jetbrains.cidr.execution.BuildTargetData
1514
import com.jetbrains.cidr.execution.BuildTargetAndConfigurationData
1615

1716
object CppTestConfiguration {
18-
fun createConfiguration(project: Project, file: VirtualFile): List<RunnerAndConfigurationSettings> {
19-
val catchFactory = CMakeCatchTestRunConfigurationType.getInstance().factory
20-
val factory = catchFactory ?: return emptyList()
17+
fun createConfiguration(project: Project, file: VirtualFile, configurationFactory: ConfigurationFactory): List<RunnerAndConfigurationSettings> {
2118
val targets = getAllCmakeTargetsForTestFiles(project, file)
22-
23-
return targets.map { createConfiguration(project, it, factory) }
19+
return targets.map { createConfiguration(project, it, configurationFactory) }
2420
}
2521

2622
private fun getAllCmakeTargetsForTestFiles(project: Project, file: VirtualFile): List<CMakeTarget> {
@@ -35,7 +31,6 @@ object CppTestConfiguration {
3531
return listOfNotNull(targets)
3632
}
3733

38-
3934
fun createConfiguration(
4035
project: Project,
4136
cMakeTarget: CMakeTarget,

0 commit comments

Comments
 (0)