feat(test): add TestAgentObserver for test failure handling #259

phodal · phodal · commit a718b80fd3d0 · 2025-03-12T16:12:48.000+08:00
Introduce TestAgentObserver to handle test failures by sending error details to the chat window. Refactor AutoDevToolWindowFactory to remove test observer logic and delegate it to the new observer. Add AgentObserver extension point and register TestAgentObserver in the application lifecycle.
diff --git a/core/src/223/main/resources/META-INF/autodev-core.xml b/core/src/223/main/resources/META-INF/autodev-core.xml
@@ -227,9 +227,12 @@
 
         <!-- mcp -->
         <extensionPoint qualifiedName="cc.unitmesh.mcpTool"
-                        interface="cc.unitmesh.devti.mcp.McpTool"
+                        interface="cc.unitmesh.devti.mcp.host.McpTool"
                         dynamic="true"/>
 
+        <extensionPoint qualifiedName="cc.unitmesh.agentObserver"
+                        interface="cc.unitmesh.devti.provider.observer.AgentObserver"
+                        dynamic="true"/>
     </extensionPoints>
 
     <applicationListeners>
diff --git a/core/src/233/main/kotlin/cc/unitmesh/devti/update/AutoDevUpdateStartupActivity.kt b/core/src/233/main/kotlin/cc/unitmesh/devti/update/AutoDevUpdateStartupActivity.kt
@@ -1,6 +1,7 @@
 package cc.unitmesh.devti.update
 
 import cc.unitmesh.devti.inline.AutoDevInlineChatProvider
+import cc.unitmesh.devti.provider.observer.AgentObserver
 import com.intellij.openapi.application.ApplicationManager
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.startup.ProjectActivity
@@ -12,5 +13,6 @@ class AutoDevUpdateStartupActivity : ProjectActivity {
         if (ApplicationManager.getApplication().isUnitTestMode) return
 
         AutoDevInlineChatProvider.addListener(project)
+        AgentObserver.register(project)
     }
 }
diff --git a/core/src/233/main/resources/META-INF/autodev-core.xml b/core/src/233/main/resources/META-INF/autodev-core.xml
@@ -229,6 +229,10 @@
         <extensionPoint qualifiedName="cc.unitmesh.mcpTool"
                         interface="cc.unitmesh.devti.mcp.host.McpTool"
                         dynamic="true"/>
+
+        <extensionPoint qualifiedName="cc.unitmesh.agentObserver"
+                        interface="cc.unitmesh.devti.provider.observer.AgentObserver"
+                        dynamic="true"/>
     </extensionPoints>
 
     <applicationListeners>
@@ -271,6 +275,8 @@
         <toolchainFunctionProvider implementation="cc.unitmesh.devti.bridge.knowledge.HistoryFunctionProvider"/>
         <toolchainFunctionProvider implementation="cc.unitmesh.devti.bridge.knowledge.KnowledgeFunctionProvider"/>
         <toolchainFunctionProvider implementation="cc.unitmesh.devti.mcp.client.McpFunctionProvider"/>
+
+        <agentObserver implementation="cc.unitmesh.devti.observer.TestAgentObserver" />
     </extensions>
 
     <actions>
diff --git a/core/src/main/kotlin/cc/unitmesh/devti/gui/AutoDevToolWindowFactory.kt b/core/src/main/kotlin/cc/unitmesh/devti/gui/AutoDevToolWindowFactory.kt
@@ -6,44 +6,32 @@ import cc.unitmesh.devti.gui.chat.ChatCodingService
 import cc.unitmesh.devti.gui.chat.NormalChatCodingPanel
 import cc.unitmesh.devti.gui.chat.message.ChatActionType
 import cc.unitmesh.devti.inline.AutoDevInlineChatProvider
+import cc.unitmesh.devti.provider.observer.AgentObserver
 import cc.unitmesh.devti.settings.locale.LanguageChangedCallback
 import cc.unitmesh.devti.settings.locale.LanguageChangedCallback.componentStateChanged
 import cc.unitmesh.devti.sketch.SketchToolWindow
-import cc.unitmesh.devti.util.relativePath
-import com.intellij.execution.testframework.sm.runner.SMTRunnerEventsAdapter
-import com.intellij.execution.testframework.sm.runner.SMTRunnerEventsListener
-import com.intellij.execution.testframework.sm.runner.SMTestProxy
-import com.intellij.openapi.Disposable
 import com.intellij.openapi.actionSystem.ex.ActionUtil
 import com.intellij.openapi.application.ApplicationManager
-import com.intellij.openapi.application.runInEdt
-import com.intellij.openapi.application.runReadAction
-import com.intellij.openapi.diagnostic.logger
 import com.intellij.openapi.project.DumbAware
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.wm.ToolWindow
 import com.intellij.openapi.wm.ToolWindowFactory
 import com.intellij.openapi.wm.ToolWindowManager
-import com.intellij.psi.search.ProjectScope
 import com.intellij.ui.content.Content
 import com.intellij.ui.content.ContentFactory
-import com.intellij.util.messages.MessageBusConnection
 
 private const val NORMAL_CHAT = "AutoDev Chat"
 private const val SKETCH_TITLE = "Sketch"
 private const val BRIDGE_TITLE = "Bridge"
 private const val CHAT_KEY = "autodev.chat"
 
-class AutoDevToolWindowFactory : ToolWindowFactory, DumbAware, Disposable {
+class AutoDevToolWindowFactory : ToolWindowFactory, DumbAware {
     object Util {
         const val id = "AutoDev"
     }
 
-    private var connection: MessageBusConnection? = null
-
     override fun createToolWindowContent(project: Project, toolWindow: ToolWindow) {
-        initInlineChatForIdea223(project)
-        initObservers(project)
+        initForIdea223(project)
         ApplicationManager.getApplication().invokeLater {
             val normalChatTitle = AutoDevBundle.messageWithLanguage(CHAT_KEY, LanguageChangedCallback.language)
             val normalChatPanel =
@@ -67,57 +55,12 @@ class AutoDevToolWindowFactory : ToolWindowFactory, DumbAware, Disposable {
         }
     }
 
-    private fun initObservers(project: Project) {
-        connection = project.messageBus.connect()
-        val searchScope = ProjectScope.getProjectScope(project)
-        connection?.subscribe(SMTRunnerEventsListener.TEST_STATUS, object : SMTRunnerEventsAdapter() {
-            override fun onSuiteFinished(suite: SMTestProxy, nodeId: String?) {
-                logger<AutoDevToolWindowFactory>().info(suite.toString())
-            }
-
-            override fun onTestFailed(test: SMTestProxy) {
-                val sourceCode = test.getLocation(project, searchScope)
-                runInEdt {
-                    sendToChatWindow(project, ChatActionType.CHAT) { contentPanel, _ ->
-                        val psiElement = sourceCode?.psiElement
-                        val language = psiElement?.language?.displayName ?: ""
-                        val filepath = psiElement?.containingFile?.virtualFile?.relativePath(project) ?: ""
-                        val code = runReadAction { psiElement?.text ?: "" }
-                        contentPanel.setInput(
-                            """Help me fix follow test issue:
-                           | ErrorMessage:
-                           |```
-                           |${test.errorMessage}
-                           |```
-                           |stacktrace details: 
-                           |${test.stacktrace}
-                           |
-                           |// filepath: $filepath
-                           |origin code:
-                           |```$language
-                           |$code
-                           |```
-                           |""".trimMargin()
-                        )
-                    }
-                }
-            }
-
-            override fun onTestFinished(test: SMTestProxy, nodeId: String?) {
-                logger<AutoDevToolWindowFactory>().info(nodeId)
-            }
-        })
-    }
-
-    override fun dispose() {
-        connection?.disconnect()
-    }
-
     /**
      * for idea 223 (aka 2022.3) which don't have [com.intellij.openapi.startup.ProjectActivity]
      */
-    private fun initInlineChatForIdea223(project: Project) {
+    private fun initForIdea223(project: Project) {
         AutoDevInlineChatProvider.addListener(project)
+        AgentObserver.register(project)
     }
 
     override fun init(toolWindow: ToolWindow) {
diff --git a/core/src/main/kotlin/cc/unitmesh/devti/observer/TestAgentObserver.kt b/core/src/main/kotlin/cc/unitmesh/devti/observer/TestAgentObserver.kt
@@ -0,0 +1,67 @@
+package cc.unitmesh.devti.observer
+
+import cc.unitmesh.devti.gui.AutoDevToolWindowFactory
+import cc.unitmesh.devti.gui.chat.message.ChatActionType
+import cc.unitmesh.devti.gui.sendToChatWindow
+import cc.unitmesh.devti.provider.observer.AgentObserver
+import cc.unitmesh.devti.util.relativePath
+import com.intellij.execution.testframework.sm.runner.SMTRunnerEventsAdapter
+import com.intellij.execution.testframework.sm.runner.SMTRunnerEventsListener.TEST_STATUS
+import com.intellij.execution.testframework.sm.runner.SMTestProxy
+import com.intellij.openapi.Disposable
+import com.intellij.openapi.application.runInEdt
+import com.intellij.openapi.application.runReadAction
+import com.intellij.openapi.diagnostic.logger
+import com.intellij.openapi.project.Project
+import com.intellij.openapi.util.NlsSafe
+import com.intellij.psi.search.ProjectScope.getProjectScope
+import com.intellij.util.messages.MessageBusConnection
+
+class TestAgentObserver : AgentObserver, Disposable {
+    private var connection: MessageBusConnection? = null
+    override fun onRegister(project: Project) {
+        connection = project.messageBus.connect()
+        val searchScope = getProjectScope(project)
+        connection?.subscribe(TEST_STATUS, object : SMTRunnerEventsAdapter() {
+            override fun onSuiteFinished(suite: SMTestProxy, nodeId: String?) {
+                logger<AutoDevToolWindowFactory>().info(suite.toString())
+            }
+
+            override fun onTestFailed(test: SMTestProxy) {
+                val sourceCode = test.getLocation(project, searchScope)
+                runInEdt {
+                    sendToChatWindow(project, ChatActionType.CHAT) { contentPanel, _ ->
+                        val psiElement = sourceCode?.psiElement
+                        val language = psiElement?.language?.displayName ?: ""
+                        val filepath = psiElement?.containingFile?.virtualFile?.relativePath(project) ?: ""
+                        val code = runReadAction<@NlsSafe String> { psiElement?.text ?: "" }
+                        contentPanel.setInput(
+                            """Help me fix follow test issue:
+                           | ErrorMessage:
+                           |```
+                           |${test.errorMessage}
+                           |```
+                           |stacktrace details: 
+                           |${test.stacktrace}
+                           |
+                           |// filepath: $filepath
+                           |origin code:
+                           |```$language
+                           |$code
+                           |```
+                           |""".trimMargin()
+                        )
+                    }
+                }
+            }
+
+            override fun onTestFinished(test: SMTestProxy, nodeId: String?) {
+                logger<TestAgentObserver>().info(nodeId)
+            }
+        })
+    }
+
+    override fun dispose() {
+        connection?.disconnect()
+    }
+}
diff --git a/core/src/main/kotlin/cc/unitmesh/devti/provider/observer/AgentObserver.kt b/core/src/main/kotlin/cc/unitmesh/devti/provider/observer/AgentObserver.kt
@@ -0,0 +1,19 @@
+package cc.unitmesh.devti.provider.observer
+
+import com.intellij.openapi.extensions.ExtensionPointName
+import com.intellij.openapi.project.Project
+
+interface AgentObserver {
+    fun onRegister(project: Project)
+
+    companion object {
+        private val EP_NAME: ExtensionPointName<AgentObserver> =
+            ExtensionPointName("cc.unitmesh.agentObserver")
+
+        fun register(project: Project) {
+            EP_NAME.extensions.forEach { observer ->
+                observer.onRegister(project)
+            }
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`package cc.unitmesh.devti.update`
`2`	`2`
`3`	`3`	`import cc.unitmesh.devti.inline.AutoDevInlineChatProvider`
	`4`	`+import cc.unitmesh.devti.provider.observer.AgentObserver`
`4`	`5`	`import com.intellij.openapi.application.ApplicationManager`
`5`	`6`	`import com.intellij.openapi.project.Project`
`6`	`7`	`import com.intellij.openapi.startup.ProjectActivity`
`@@ -12,5 +13,6 @@ class AutoDevUpdateStartupActivity : ProjectActivity {`
`12`	`13`	`if (ApplicationManager.getApplication().isUnitTestMode) return`
`13`	`14`
`14`	`15`	`AutoDevInlineChatProvider.addListener(project)`
	`16`	`+ AgentObserver.register(project)`
`15`	`17`	`}`
`16`	`18`	`}`