fix(compiler): return null instead of error message for missing file

phodal · phodal · commit c225e03f88d3 · 2025-01-18T11:27:59.000+08:00
Simplify error handling in FileInsCommand by returning null when a file is not found, instead of a string error message. This aligns with the expected behavior of the command execution.
diff --git a/exts/devins-lang/src/main/kotlin/cc/unitmesh/devti/language/compiler/exec/FileInsCommand.kt b/exts/devins-lang/src/main/kotlin/cc/unitmesh/devti/language/compiler/exec/FileInsCommand.kt
@@ -34,7 +34,8 @@ class FileInsCommand(private val myProject: Project, private val prop: String) :
         val contentsToByteArray = virtualFile?.contentsToByteArray()
         if (contentsToByteArray == null) {
             AutoDevNotifications.warn(myProject, "File not found: $prop")
-            return null
+            /// not show error message to just notify
+            return "File not found: $prop"
         }
 
         InsCommandListener.notify(this, InsCommandStatus.SUCCESS, virtualFile)

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,8 @@ class FileInsCommand(private val myProject: Project, private val prop: String) :`
`34`	`34`	`val contentsToByteArray = virtualFile?.contentsToByteArray()`
`35`	`35`	`if (contentsToByteArray == null) {`
`36`	`36`	`AutoDevNotifications.warn(myProject, "File not found: $prop")`
`37`		`- return null`
	`37`	`+ /// not show error message to just notify`
	`38`	`+ return "File not found: $prop"`
`38`	`39`	`}`
`39`	`40`
`40`	`41`	`InsCommandListener.notify(this, InsCommandStatus.SUCCESS, virtualFile)`