refactor(terminal): improve shell syntax safety check #335

- Remove unnecessary import of ShFile
- Simplify command parsing in checkDangerousCommand function
- Update test cases to use new checkDangerousCommand function

Author: phodal

exts/ext-terminal/src/main/kotlin/cc/unitmesh/terminal/sketch/ShellSyntaxSafetyCheck.kt

@@ -5,7 +5,6 @@ import com.intellij.psi.PsiFileFactory
 import com.intellij.psi.util.PsiTreeUtil
 import com.intellij.sh.ShLanguage
 import com.intellij.sh.psi.ShCommand
-import com.intellij.sh.psi.ShFile
 
 object ShellSyntaxSafetyCheck {
     private val checkerRegistry = ShellCommandCheckerRegistry()
@@ -27,7 +26,7 @@ object ShellSyntaxSafetyCheck {
      */
     fun checkDangerousCommand(project: Project, command: String): Pair<Boolean, String> {
         val psiFile = PsiFileFactory.getInstance(project)
-            .createFileFromText("temp.sh", ShLanguage.INSTANCE, command) as? ShFile
+            .createFileFromText("temp.sh", ShLanguage.INSTANCE, command)
             ?: return Pair(true, "Could not parse command")
 
         val commandElements = PsiTreeUtil.findChildrenOfType(psiFile, ShCommand::class.java)

exts/ext-terminal/src/test/kotlin/cc/unitmesh/terminal/sketch/ShellSyntaxSafetyCheckTest.kt

@@ -14,7 +14,7 @@ class ShellSyntaxSafetyCheckTest : BasePlatformTestCase() {
         )
 
         for (command in safeCommands) {
-            val result = ShellSyntaxSafetyCheck.checkDangerousCommandByPsi(project, command)
+            val result = ShellSyntaxSafetyCheck.checkDangerousCommand(project, command)
             assertFalse("Should be safe: $command", result.first)
             assertEquals("", result.second)
         }
@@ -30,14 +30,14 @@ class ShellSyntaxSafetyCheckTest : BasePlatformTestCase() {
         )
 
         for ((command, expectedMessage) in dangerousCommands) {
-            val result = ShellSyntaxSafetyCheck.checkDangerousCommandByPsi(project, command)
+            val result = ShellSyntaxSafetyCheck.checkDangerousCommand(project, command)
             assertTrue("Should be dangerous: $command", result.first)
             assertEquals(expectedMessage, result.second)
         }
 
         // Test fork bomb
         val forkBomb = ":(){ :|:& };:"
-        val result = ShellSyntaxSafetyCheck.checkDangerousCommandByPsi(project, forkBomb)
+        val result = ShellSyntaxSafetyCheck.checkDangerousCommand(project, forkBomb)
         assertTrue("Fork bomb should be detected", result.first)
         assertEquals("Potential fork bomb", result.second)
     }