Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Commit 133b821

Browse files
committed
fix: prevent events mutating state on empty removes
1 parent c59628f commit 133b821

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

packages/core/src/storage/sovranStorage.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,9 @@ export class SovranStorage implements Storage {
195195
remove: (event: SegmentEvent | SegmentEvent[]) => {
196196
this.eventsStore.dispatch((state) => {
197197
const eventsToRemove = Array.isArray(event) ? event : [event];
198+
if (eventsToRemove.length === 0 || state.events.length === 0) {
199+
return state;
200+
}
198201
const setToRemove = new Set(eventsToRemove);
199202
const filteredEvents = state.events.filter((e) => !setToRemove.has(e));
200203
return { events: filteredEvents };

0 commit comments

Comments
 (0)