fix(android): fix crash when promise resolves in debug mode (segmentio#267)

bsneed · Brandon Sneed · web-flow · commit a0e21d963e8d · 2021-02-08T11:55:38.000-08:00
* fix(android): fix crash when promise resolves in debug mode

* fix(ci): update config.yml

Co-authored-by: Brandon Sneed &lt;brandon.sneed@segment.com&gt;
diff --git a/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt b/packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt
@@ -112,7 +112,7 @@ class RNAnalyticsModule(context: ReactApplicationContext): ReactContextBaseJavaM
             }
             else {
                 if (BuildConfig.DEBUG) {
-                    return promise.resolve(this)
+                    return promise.resolve(null)
                 }
                 else {
                     return promise.reject("E_SEGMENT_RECONFIGURED", "Segment Analytics Client was allocated multiple times, please check your environment.")

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ class RNAnalyticsModule(context: ReactApplicationContext): ReactContextBaseJavaM`
`112`	`112`	`}`
`113`	`113`	`else {`
`114`	`114`	`if (BuildConfig.DEBUG) {`
`115`		`- return promise.resolve(this)`
	`115`	`+ return promise.resolve(null)`
`116`	`116`	`}`
`117`	`117`	`else {`
`118`	`118`	`return promise.reject("E_SEGMENT_RECONFIGURED", "Segment Analytics Client was allocated multiple times, please check your environment.")`