fix(core): React-Native 0.59 Support (segmentio#50)

- React-Native 0.59 support
- Upgrade Detox 9 -> 12
- Upgrade test-app to React-Native 0.59.2
- Commit test-app to git

Fixes segmentio#46
Closes segmentio#44 

---

Ref: LIB-909

Author: fathyb

.circleci/config.yml

@@ -100,7 +100,6 @@ jobs:
       - checkout
       - *getDeps
       - *attach
-
       - run: yarn test-app test:android
 
   test-ios-vanilla:

.prettierignore

@@ -1,3 +1,4 @@
 packages/core/docs/
 build/
 node_modules/
+packages/test-app/seed/

package.json

@@ -58,6 +58,7 @@
     ]
   },
   "devDependencies": {
+    "@babel/core": "^7.4.0",
     "@commitlint/cli": "^7.0.0",
     "@commitlint/config-conventional": "^7.0.1",
     "codecov": "^3.0.4",
@@ -68,8 +69,8 @@
     "lint-staged": "^7.2.0",
     "npm-run-all": "^4.1.3",
     "prettier": "^1.14.2",
-    "react": "16.6.1",
-    "react-native": "^0.57.3",
+    "react": "16.8.3",
+    "react-native": "0.59.2",
     "rimraf": "^2.6.2"
   }
 }

packages/core/android/build.gradle

@@ -8,7 +8,7 @@ buildscript {
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:3.1.4'
-        classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.2.60'
+        classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.21'
     }
 }
 
@@ -41,5 +41,5 @@ dependencies {
     api 'com.segment.analytics.android:analytics:4.+'
 
     api 'com.facebook.react:react-native:+'
-    api 'org.jetbrains.kotlin:kotlin-stdlib:1.2.+'
+    api 'org.jetbrains.kotlin:kotlin-stdlib:1.3.21'
 }

packages/core/docs/README.md

@@ -22,10 +22,9 @@
 
 ###  Integration
 
-**Ƭ Integration**: * `function` | `object`
-*
+**Ƭ Integration**: *`function` \| `object`*
 
-*Defined in analytics.ts:8*
+*Defined in [analytics.ts:8](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L8)*
 
 ___
 

packages/core/docs/classes/analytics.client.md

@@ -38,7 +38,7 @@
 
 **● ready**: *`false`* = false
 
-*Defined in analytics.ts:96*
+*Defined in [analytics.ts:96](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L96)*
 
 Whether the client is ready to send events to Segment.
 
@@ -54,7 +54,7 @@ ___
 
 ▸ **alias**(newId: *`string`*): `Promise`<`void`>
 
-*Defined in analytics.ts:260*
+*Defined in [analytics.ts:260](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L260)*
 
 Merge two user identities, effectively connecting two sets of user data as one. This may not be supported by all integrations.
 
@@ -75,7 +75,7 @@ ___
 
 ▸ **catch**(handler: *[ErrorHandler]()*): `this`
 
-*Defined in analytics.ts:109*
+*Defined in [analytics.ts:109](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L109)*
 
 Catch React-Native bridge errors
 
@@ -96,7 +96,7 @@ ___
 
 ▸ **disable**(): `Promise`<`void`>
 
-*Defined in analytics.ts:299*
+*Defined in [analytics.ts:299](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L299)*
 
 Completely disable the sending of any analytics data.
 
@@ -111,7 +111,7 @@ ___
 
 ▸ **enable**(): `Promise`<`void`>
 
-*Defined in analytics.ts:289*
+*Defined in [analytics.ts:289](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L289)*
 
 Enable the sending of analytics data. Enabled by default.
 
@@ -126,7 +126,7 @@ ___
 
 ▸ **flush**(): `Promise`<`void`>
 
-*Defined in analytics.ts:280*
+*Defined in [analytics.ts:280](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L280)*
 
 Trigger an upload of all queued events.
 
@@ -141,7 +141,7 @@ ___
 
 ▸ **group**(groupId: *`string`*, traits?: *[JsonMap]()*): `Promise`<`void`>
 
-*Defined in analytics.ts:247*
+*Defined in [analytics.ts:247](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L247)*
 
 Associate a user with a group, organization, company, project, or w/e _you_ call them.
 
@@ -163,7 +163,7 @@ ___
 
 ▸ **identify**(user: *`string`*, traits?: *[JsonMap]()*): `Promise`<`void`>
 
-*Defined in analytics.ts:235*
+*Defined in [analytics.ts:235](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L235)*
 
 Associate a user with their unique ID and record traits about them.
 
@@ -185,7 +185,7 @@ ___
 
 ▸ **middleware**(middleware: *[Middleware]()*): `this`
 
-*Defined in analytics.ts:147*
+*Defined in [analytics.ts:147](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L147)*
 
 Append a new middleware to the middleware chain.
 
@@ -223,7 +223,7 @@ ___
 
 ▸ **reset**(): `Promise`<`void`>
 
-*Defined in analytics.ts:270*
+*Defined in [analytics.ts:270](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L270)*
 
 Reset any user state that is cached on the device.
 
@@ -238,7 +238,7 @@ ___
 
 ▸ **screen**(name: *`string`*, properties?: *[JsonMap]()*): `Promise`<`void`>
 
-*Defined in analytics.ts:221*
+*Defined in [analytics.ts:221](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L221)*
 
 Record the screens or views your users see.
 
@@ -260,7 +260,7 @@ ___
 
 ▸ **setup**(writeKey: *`string`*, configuration?: *[Configuration](../interfaces/analytics.configuration.md)*): `Promise`<`void`>
 
-*Defined in analytics.ts:186*
+*Defined in [analytics.ts:186](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L186)*
 
 Setup the Analytics module. All calls made before are queued and only executed if the configuration was successful.
 
@@ -290,7 +290,7 @@ ___
 
 ▸ **track**(event: *`string`*, properties?: *[JsonMap]()*): `Promise`<`void`>
 
-*Defined in analytics.ts:203*
+*Defined in [analytics.ts:203](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L203)*
 
 Record the actions your users perform.
 
@@ -312,7 +312,7 @@ ___
 
 ▸ **useNativeConfiguration**(): `this`
 
-*Defined in analytics.ts:159*
+*Defined in [analytics.ts:159](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L159)*
 
 Use the native configuration.
 

packages/core/docs/interfaces/analytics.configuration.md

@@ -27,10 +27,9 @@
 
 ### `<Optional>` android
 
-**● android**: * `undefined` &#124; `object`
-*
+**● android**: *`undefined` \| `object`*
 
-*Defined in analytics.ts:69*
+*Defined in [analytics.ts:69](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L69)*
 
 Android specific settings.
 
@@ -39,20 +38,18 @@ ___
 
 ### `<Optional>` debug
 
-**● debug**: * `undefined` &#124; `false` &#124; `true`
-*
+**● debug**: *`undefined` \| `false` \| `true`*
 
-*Defined in analytics.ts:38*
+*Defined in [analytics.ts:38](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L38)*
 
 ___
 <a id="flushat"></a>
 
 ### `<Optional>` flushAt
 
-**● flushAt**: * `undefined` &#124; `number`
-*
+**● flushAt**: *`undefined` \| `number`*
 
-*Defined in analytics.ts:46*
+*Defined in [analytics.ts:46](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L46)*
 
 The number of queued events that the analytics client should flush at. Setting this to `1` will not queue any events and will use more battery.
 
@@ -63,10 +60,9 @@ ___
 
 ### `<Optional>` ios
 
-**● ios**: * `undefined` &#124; `object`
-*
+**● ios**: *`undefined` \| `object`*
 
-*Defined in analytics.ts:51*
+*Defined in [analytics.ts:51](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L51)*
 
 iOS specific settings.
 
@@ -75,10 +71,9 @@ ___
 
 ### `<Optional>` recordScreenViews
 
-**● recordScreenViews**: * `undefined` &#124; `false` &#124; `true`
-*
+**● recordScreenViews**: *`undefined` \| `false` \| `true`*
 
-*Defined in analytics.ts:17*
+*Defined in [analytics.ts:19](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L19)*
 
 Whether the analytics client should automatically make a screen call when a view controller is added to a view hierarchy. Because the iOS underlying implementation uses method swizzling, we recommend initializing the analytics client as early as possible.
 
@@ -89,10 +84,9 @@ ___
 
 ### `<Optional>` trackAppLifecycleEvents
 
-**● trackAppLifecycleEvents**: * `undefined` &#124; `false` &#124; `true`
-*
+**● trackAppLifecycleEvents**: *`undefined` \| `false` \| `true`*
 
-*Defined in analytics.ts:26*
+*Defined in [analytics.ts:26](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L26)*
 
 Whether the analytics client should automatically track application lifecycle events, such as "Application Installed", "Application Updated" and "Application Opened".
 
@@ -103,10 +97,9 @@ ___
 
 ### `<Optional>` trackAttributionData
 
-**● trackAttributionData**: * `undefined` &#124; `false` &#124; `true`
-*
+**● trackAttributionData**: *`undefined` \| `false` \| `true`*
 
-*Defined in analytics.ts:32*
+*Defined in [analytics.ts:32](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L32)*
 
 Whether the analytics client should automatically track attribution data from enabled providers using the mobile service.
 
@@ -119,7 +112,7 @@ ___
 
 **● using**: *[Integration](../#integration)[]*
 
-*Defined in analytics.ts:37*
+*Defined in [analytics.ts:37](https://github.com/segmentio/analytics-react-native/blob/master/packages/core/src/analytics.ts#L37)*
 
 Register a set of integrations to be used with this Analytics instance.
 

packages/core/src/__tests__/analytics.spec.ts

@@ -37,7 +37,9 @@ it('catches bridge errors', async () => {
 	const error = new Error('test-error')
 	const onError = jest.fn()
 
-	getBridgeStub('track').mockImplementationOnce(() => Promise.reject(error))
+	getBridgeStub('track').mockImplementationOnce(
+		() => Promise.reject(error) as any
+	)
 	analytics.catch(onError)
 	analytics.track('test')
 
@@ -82,7 +84,9 @@ it('logs uncaught bridge errors', async () => {
 		message: 'test-error'
 	}
 
-	getBridgeStub('track').mockImplementationOnce(() => Promise.reject(error))
+	getBridgeStub('track').mockImplementationOnce(
+		() => Promise.reject(error) as any
+	)
 
 	expect(analytics.track('test')).rejects.toBe(error)
 	expect(console.error).not.toHaveBeenCalled()

packages/core/src/__tests__/configuration.spec.ts

@@ -60,7 +60,7 @@ it('produces a valid configuration', async () => {
 })
 
 it('waits for integrations to register', async () => {
-	const stub = jest.fn(t => setTimeout(t, 500))
+	const stub: any = jest.fn(t => setTimeout(t, 500))
 
 	await configure(writeKey, {
 		using: [() => ({ then: stub })]

packages/integrations/template/android/build.gradle

@@ -8,7 +8,7 @@ buildscript {
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:3.1.4'
-        classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.2.60'
+        classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.0'
     }
 }
 

packages/test-app/android-workaround.js

@@ -0,0 +1,4 @@
+{
+  "setupFilesAfterEnv": ["./init.js"],
+  "testEnvironment": "node"
+}

packages/test-app/e2e/config.json

@@ -1,21 +1,21 @@
 const detox = require('detox')
 const config = require('../package.json').detox
-const adapter = require('detox/runners/mocha/adapter')
+const adapter = require('detox/runners/jest/adapter')
 
 require('isomorphic-fetch')
 
-before(async () => {
-	await detox.init(config)
-})
+jest.setTimeout(120000)
+jasmine.getEnv().addReporter(adapter)
 
-beforeEach(async function() {
-	await adapter.beforeEach(this)
+beforeAll(async () => {
+	await detox.init(config)
 })
 
-afterEach(async function() {
-	await adapter.afterEach(this)
+beforeEach(async () => {
+	await adapter.beforeEach()
 })
 
-after(async () => {
+afterAll(async () => {
+	await adapter.afterAll()
 	await detox.cleanup()
 })

packages/test-app/e2e/init.js

@@ -20,7 +20,7 @@ if (CIRCLE_WORKFLOW_ID) {
 		await element(by.text('Flush')).tap()
 
 		await Promise.all(
-			require('../src/calls.json').map(([type, ...args]) =>
+			require('../seed/calls.json').map(([type, ...args]) =>
 				hasMatchingCall(type, ...args)
 			)
 		)