Logic to handle Integrations listed under maybeBundledConfigIds (segmentio#564)

* fix: set maybe bundled to unbundled if not added as plugin

* fix: set maybe bundled to unbundled if not added as plugin

* fix: add test for empty maybeconfig

Co-authored-by: Niall Brennan <[email protected]>

Author: niallzato

packages/core/src/plugins/DestinationMetadataEnrichment.ts

@@ -37,9 +37,18 @@ export class DestinationMetadataEnrichment extends UtilityPlugin {
     const unbundled: string[] = [];
     const segmentInfo =
       (pluginSettings[this.destinationKey] as Record<string, any>) ?? {};
-    const unbundledIntegrations: string[] =
+    var unbundledIntegrations: string[] =
       segmentInfo.unbundledIntegrations ?? [];
 
+    if (segmentInfo.maybeBundledConfigIds) {
+      const maybeBundledIntegrations: string[] = Object.keys(
+        segmentInfo.maybeBundledConfigIds
+      );
+      unbundledIntegrations = unbundledIntegrations.concat(
+        maybeBundledIntegrations
+      );
+    }
+
     for (const integration of unbundledIntegrations) {
       if (!bundled.includes(integration)) {
         unbundled.push(integration);

packages/core/src/plugins/__tests__/SegmentDestination.test.ts

@@ -96,6 +96,7 @@ describe('SegmentDestination', () => {
         settings: {
           [SEGMENT_DESTINATION_KEY]: {
             unbundledIntegrations: ['firebase'],
+            maybeBundledConfigIds: {},
           },
         },
       }),
@@ -131,6 +132,43 @@ describe('SegmentDestination', () => {
     });
   });
 
+  it('marks maybeBundled integrations to unbundled if they are not bundled', () => {
+    const plugin = new SegmentDestination();
+    const analytics = new SegmentClient({
+      ...clientArgs,
+      store: new MockSegmentStore({
+        settings: {
+          [SEGMENT_DESTINATION_KEY]: {
+            unbundledIntegrations: ['Amplitude'],
+            maybeBundledConfigIds: { Mixpanel: ['123'] },
+          },
+        },
+      }),
+    });
+    plugin.configure(analytics);
+
+    const event: TrackEventType = {
+      anonymousId: '3534a492-e975-4efa-a18b-3c70c562fec2',
+      event: 'Awesome event',
+      type: EventType.TrackEvent,
+      properties: {},
+      timestamp: '2000-01-01T00:00:00.000Z',
+      messageId: '1d1744bf-5beb-41ac-ad7a-943eac33babc',
+      context: { app: { name: 'TestApp' } },
+      integrations: {},
+    };
+
+    const result = plugin.execute(event);
+    expect(result).toEqual({
+      ...event,
+      _metadata: {
+        bundled: [],
+        unbundled: ['Amplitude', 'Mixpanel'],
+        bundledIds: [],
+      },
+    });
+  });
+
   it('lets plugins/events override destination settings', () => {
     const plugin = new SegmentDestination();
     // @ts-ignore