[test] separate tracing error test from action test suite

huozhi · huozhi · commit 792f6f276975 · 2025-06-09T18:01:40.000+02:00
diff --git a/test/e2e/app-dir/actions/app-action.test.ts b/test/e2e/app-dir/actions/app-action.test.ts
@@ -10,7 +10,7 @@ import {
 import type { Request, Response } from 'playwright'
 import fs from 'fs-extra'
 import nodeFs from 'fs'
-import path, { join } from 'path'
+import { join } from 'path'
 import { outdent } from 'outdent'
 
 const GENERIC_RSC_ERROR =
@@ -31,17 +31,6 @@ describe('app-dir action handling', () => {
       },
     })
 
-  if (isNextStart) {
-    it('should trace server action imported by client correctly', async () => {
-      const traceData = await next.readJSON(
-        path.join('.next', 'server', 'app', 'client', 'page.js.nft.json')
-      )
-      expect(traceData.files.some((file) => file.includes('data.txt'))).toBe(
-        true
-      )
-    })
-  }
-
   it('should handle action correctly with middleware rewrite', async () => {
     const browser = await next.browser('/rewrite-to-static-first')
     let actionRequestStatus: number | undefined
@@ -1923,7 +1912,7 @@ describe('app-dir action handling', () => {
   })
 
   describe('request body decoding', () => {
-    it.each(['node', 'edge'])(
+    it.each(['edge'])(
       'should correctly decode multi-byte characters in the request body (%s)',
       async (runtime) => {
         const browser = await next.browser(`/decode-req-body/${runtime}`)
diff --git a/test/e2e/app-dir/actions/app/client/actions.js b/test/e2e/app-dir/actions/app/client/actions.js
@@ -5,13 +5,6 @@ import 'server-only'
 import { redirect } from 'next/navigation'
 import { headers, cookies } from 'next/headers'
 
-try {
-  require('fs').readFileSync(
-    require('path').join(process.cwd(), 'data.txt'),
-    'utf8'
-  )
-} catch {}
-
 export async function getHeaders() {
   console.log('accept header:', (await headers()).get('accept'))
   ;(await cookies()).set('test-cookie', Date.now())
diff --git a/test/e2e/app-dir/actions/data.txt b/test/e2e/app-dir/actions/data.txt
diff --git a/test/production/app-dir/action-tracing/action-tracing.test.ts b/test/production/app-dir/action-tracing/action-tracing.test.ts
@@ -0,0 +1,19 @@
+import { nextTestSetup } from 'e2e-utils'
+import path from 'path'
+
+describe('action-tracing', () => {
+  const { next, skipped } = nextTestSetup({
+    files: __dirname,
+    skipDeployment: true,
+  })
+  if (skipped) return
+
+  it('should trace server action imported by client correctly', async () => {
+    const traceData = (await next.readJSON(
+      path.join('.next', 'server', 'app', 'page.js.nft.json')
+    )) as {
+      files: string[]
+    }
+    expect(traceData.files.some((file) => file.includes('data.txt'))).toBe(true)
+  })
+})
diff --git a/test/production/app-dir/action-tracing/app/action.ts b/test/production/app-dir/action-tracing/app/action.ts
@@ -0,0 +1,14 @@
+'use server'
+
+try {
+  if (process.env.NEXT_RUNTIME !== 'edge') {
+    require('fs').readFileSync(
+      require('path').join(process.cwd(), 'data.txt'),
+      'utf8'
+    )
+  }
+} catch {}
+
+export async function action() {
+  return 'action'
+}
diff --git a/test/production/app-dir/action-tracing/app/layout.tsx b/test/production/app-dir/action-tracing/app/layout.tsx
@@ -0,0 +1,8 @@
+import { ReactNode } from 'react'
+export default function Root({ children }: { children: ReactNode }) {
+  return (
+    <html>
+      <body>{children}</body>
+    </html>
+  )
+}
diff --git a/test/production/app-dir/action-tracing/app/page.tsx b/test/production/app-dir/action-tracing/app/page.tsx
@@ -0,0 +1,15 @@
+'use client'
+
+import { action } from './action'
+
+export default function Page() {
+  return (
+    <button
+      onClick={() => {
+        action()
+      }}
+    >
+      click
+    </button>
+  )
+}
diff --git a/test/production/app-dir/action-tracing/data.txt b/test/production/app-dir/action-tracing/data.txt
@@ -0,0 +1 @@
+data
diff --git a/test/production/app-dir/action-tracing/next.config.js b/test/production/app-dir/action-tracing/next.config.js
@@ -0,0 +1,6 @@
+/**
+ * @type {import('next').NextConfig}
+ */
+const nextConfig = {}
+
+module.exports = nextConfig
