Skip to content

Commit f6f4876

Browse files
committed
Give up on this
Just bad UX. Marks the whole PR red and then you want to rerun but that doesn't do shit. Let's just assume build_and_deploy will always finish before test
1 parent ba35963 commit f6f4876

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

.github/workflows/build_and_deploy.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -696,17 +696,10 @@ jobs:
696696

697697
buildPassed:
698698
needs: ['deploy-target', 'build', 'build-wasm', 'build-native']
699-
if: always()
699+
if: ${{ always() && needs.deploy-target.outputs.value != '' }}
700700
name: thank you, build
701701
runs-on: ubuntu-latest
702702
steps:
703-
- name: Waiting for passing build_and_deploy from push event
704-
# If we bailed out early, don't mark this as passed i.e. deploy-target must
705-
# have passed. Everything else can be skipped.
706-
# We assume that a workflow from a different event is still running
707-
# and eventually produces a passed job.
708-
if: ${{ needs.deploy-target.outputs.value == '' }}
709-
run: exit 1
710703
- run: exit 1
711704
if: ${{ always() && (contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')) }}
712705

0 commit comments

Comments
 (0)