Skip to content

RSDK-10928: Add support for gRPC latency metrics. #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 11, 2025
Merged

RSDK-10928: Add support for gRPC latency metrics. #4996

merged 12 commits into from
Jun 11, 2025

Conversation

dgottlieb
Copy link
Member

@dgottlieb dgottlieb commented May 19, 2025 •
edited
Loading

Also fix some charting bugs:

  • When there are lots of datapoints we scale down to 1000. This didn't play nicely when there was also a bubble in receiving ftdc metrics/time jumping forward.
  • Ensure all graphs have the same start time. Even if a metric only comes into existence well after a robot starts up.
  • Document the existing event command that highlights interesting times for all graphs. In order to better visually scan for correlations.
  • Draw steeper lines when infrequent events occur on "deferred" or "ratio" computed graphs.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label May 19, 2025
@dgottlieb dgottlieb added github_actions Pull requests that update GitHub Actions code appimage-ignore-tests Build AppImage of PR and ignore tests static-ignore-tests Build static binaries from PR and ignore tests safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone github_actions Pull requests that update GitHub Actions code appimage-ignore-tests Build AppImage of PR and ignore tests static-ignore-tests Build static binaries from PR and ignore tests labels May 19, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 19, 2025
@dgottlieb dgottlieb removed the appimage-ignore-tests Build AppImage of PR and ignore tests label May 19, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels May 19, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 10, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 11, 2025
@dgottlieb dgottlieb requested a review from cheukt June 11, 2025 13:09
@dgottlieb dgottlieb removed the static-ignore-tests Build static binaries from PR and ignore tests label Jun 11, 2025
@dgottlieb dgottlieb changed the title Ftdc RSDK-10928: Add support for gRPC latency metrics. Jun 11, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 11, 2025
@dgottlieb
Copy link
Member Author

I've added some images to the ticket.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 11, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jun 11, 2025
@dgottlieb dgottlieb merged commit f6fe96d into viamrobotics:main Jun 11, 2025
18 checks passed
@dgottlieb dgottlieb deleted the ftdc branch June 11, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheukt cheukt cheukt approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgottlieb @cheukt @viambot