Skip to content

Commit 1097bd1

Browse files
update base properties
1 parent 28e91eb commit 1097bd1

File tree

5 files changed

+9
-4
lines changed

5 files changed

+9
-4
lines changed

examples/server/v1/components.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ def __init__(self, name: str):
184184
self.angular_pwr = Vector3(x=0, y=0, z=0)
185185
self.linear_vel = Vector3(x=0, y=0, z=0)
186186
self.angular_vel = Vector3(x=0, y=0, z=0)
187-
self.props = Base.Properties(1.0, 1.0)
187+
self.props = Base.Properties(1.0, 1.0, 1.0)
188188
super().__init__(name)
189189

190190
async def move_straight(self, distance: int, velocity: float, extra: Optional[Dict[str, Any]] = None, **kwargs):

src/viam/components/base/base.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ class Base(ComponentBase):
2323
class Properties:
2424
width_meters: float
2525
turning_radius_meters: float
26+
wheel_circumference_meters: float
2627

2728
@abc.abstractmethod
2829
async def move_straight(

src/viam/components/base/client.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,9 @@ async def get_properties(self, *, extra: Optional[Dict[str, Any]] = None, timeou
119119
extra = {}
120120
request = GetPropertiesRequest(name=self.name, extra=dict_to_struct(extra))
121121
response: GetPropertiesResponse = await self.client.GetProperties(request, timeout=timeout)
122-
return Base.Properties(width_meters=response.width_meters, turning_radius_meters=response.turning_radius_meters)
122+
return Base.Properties(width_meters=response.width_meters,
123+
turning_radius_meters=response.turning_radius_meters,
124+
wheel_circumference_meters=response.wheel_circumference_meters)
123125

124126
async def do_command(
125127
self,

src/viam/components/base/service.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,9 @@ async def GetProperties(self, stream: Stream[GetPropertiesRequest, GetProperties
112112
base = self.get_resource(name)
113113
timeout = stream.deadline.time_remaining() if stream.deadline else None
114114
properties = await base.get_properties(timeout=timeout, metadata=stream.metadata)
115-
response = GetPropertiesResponse(width_meters=properties.width_meters, turning_radius_meters=properties.turning_radius_meters)
115+
response = GetPropertiesResponse(width_meters=properties.width_meters,
116+
turning_radius_meters=properties.turning_radius_meters,
117+
wheel_circumference_meters=properties.wheel_circumference_meters)
116118
await stream.send_message(response)
117119

118120
async def DoCommand(self, stream: Stream[DoCommandRequest, DoCommandResponse]) -> None:

tests/mocks/components.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def __init__(self, name: str):
176176
self.geometries = GEOMETRIES
177177
self.extra: Optional[Dict[str, Any]] = None
178178
self.timeout: Optional[float] = None
179-
self.props = Base.Properties(1.0, 1.0)
179+
self.props = Base.Properties(1.0, 1.0, 1.0)
180180
super().__init__(name)
181181

182182
async def move_straight(

0 commit comments

Comments
 (0)