rc-0.4.8 (#389)

Co-authored-by: stuqdog <[email protected]>
Co-authored-by: Cheuk <[email protected]>
Co-authored-by: Cheuk Tse <[email protected]>
Co-authored-by: njooma <[email protected]>

Author: 4 people

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "viam-sdk"
-version = "0.4.7"
+version = "0.4.8"
 description = "Viam Robotics Python SDK"
 authors = [ "Naveed <[email protected]>" ]
 license = "Apache-2.0"

src/viam/resource/types.py

@@ -33,9 +33,9 @@ class Subtype:
     """The subtype of the resource e.g. `servo`, `arm`, `vision`"""
 
     def __init__(self, namespace: str, resource_type: str, resource_subtype: str):
-        self.namespace = namespace.lower()
-        self.resource_type = resource_type.lower()
-        self.resource_subtype = resource_subtype.lower()
+        self.namespace = namespace
+        self.resource_type = resource_type
+        self.resource_subtype = resource_subtype
 
     def __str__(self) -> str:
         return f"{self.namespace}:{self.resource_type}:{self.resource_subtype}"
@@ -95,8 +95,8 @@ class ModelFamily:
     DEFAULT: ClassVar["ModelFamily"]
 
     def __init__(self, namespace: str, family: str):
-        self.namespace = namespace.lower()
-        self.family = family.lower()
+        self.namespace = namespace
+        self.family = family
 
     def __str__(self) -> str:
         return f"{self.namespace}:{self.family}"
@@ -125,7 +125,7 @@ class Model:
 
     def __init__(self, model_family: ModelFamily, name: str):
         self.model_family = model_family
-        self.name = name.lower()
+        self.name = name
 
     def __str__(self) -> str:
         return f"{self.model_family}:{self.name}"

tests/test_registry.py

@@ -65,8 +65,8 @@ def test_subtype():
     # test fields should always be lowercase
     subtype = Subtype("test", "TEST", "TeSt")
     assert subtype.namespace == "test"
-    assert subtype.resource_type == "test"
-    assert subtype.resource_subtype == "test"
+    assert subtype.resource_type != "test"
+    assert subtype.resource_subtype != "test"
 
     # test from resource name
     rn = Arm.get_resource_name("test_arm")
@@ -75,25 +75,25 @@ def test_subtype():
 
     # test from string
     subtype = Subtype.from_string("TEST:tester:TESTerson")
-    assert subtype.namespace == "test"
+    assert subtype.namespace != "test"
     assert subtype.resource_type == "tester"
-    assert subtype.resource_subtype == "testerson"
+    assert subtype.resource_subtype != "testerson"
 
     with pytest.raises(ValueError):
         Subtype.from_string("this:should:not:work")
 
     # test str
-    assert str(subtype) == "test:tester:testerson"
+    assert str(subtype) != "test:tester:testerson"
 
 
 def test_model_family():
     # test fields should always be lowercase
     mf = ModelFamily("nameSPACE", "FAMily")
-    assert mf.namespace == "namespace"
-    assert mf.family == "family"
+    assert mf.namespace != "namespace"
+    assert mf.family != "family"
 
     # test str
-    assert str(mf) == "namespace:family"
+    assert str(mf) != "namespace:family"
 
     # test default
     assert ModelFamily.DEFAULT.namespace == RESOURCE_NAMESPACE_RDK
@@ -103,10 +103,10 @@ def test_model_family():
 def test_model():
     # test fields should always be lowercase
     model = Model(ModelFamily("nameSPACE", "FAMily"), "naME")
-    assert model.name == "name"
+    assert model.name != "name"
 
     # test str
-    assert str(model) == "namespace:family:name"
+    assert str(model) != "namespace:family:name"
 
     # test from_string
     model = Model.from_string("f_namespace:f_family:name")