RSDK-4477 update move on globe wrapper #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpertsov
commented
Aug 16, 2023
Comment on lines
+63
to
+78
| export const encodeMotionConfiguration = ( | ||
| obj: MotionConfiguration | ||
| ): pb.MotionConfiguration => { | ||
| const result = new pb.MotionConfiguration(); | ||
|
|
||
| result.setVisionServicesList( | ||
| obj.visionServicesList.map((x) => encodeResourceName(x)) | ||
| ); | ||
| result.setPositionPollingFrequencyHz(obj.positionPollingFrequencyHz); | ||
| result.setObstaclePollingFrequencyHz(obj.obstaclePollingFrequencyHz); | ||
| result.setPlanDeviationM(obj.planDeviationM); | ||
| result.setLinearMPerSec(obj.linearMPerSec); | ||
| result.setAngularDegsPerSec(obj.angularDegsPerSec); | ||
|
|
||
| return result; | ||
| }; |
There was a problem hiding this comment.
annoying, all of these fields are required in the resulting protobuf object, even tho they are marked as optional in the source proto file
There was a problem hiding this comment.
That's weird. Why are they required if they're supposed to be optional?
There was a problem hiding this comment.
yeah I'm not sure... but we can resolve this later since make them optional will still be backwards compatible - for now i just want to get his building again
maximpertsov
commented
Aug 16, 2023
| extra = {} | ||
| ) { | ||
| const { service } = this; | ||
|
|
||
| const request = new pb.MoveOnGlobeRequest(); | ||
| request.setName(this.name); |
There was a problem hiding this comment.
this is a bug unrelated to the motion api change
purplenicole730
approved these changes
Aug 16, 2023
Comment on lines
+63
to
+78
| export const encodeMotionConfiguration = ( | ||
| obj: MotionConfiguration | ||
| ): pb.MotionConfiguration => { | ||
| const result = new pb.MotionConfiguration(); | ||
|
|
||
| result.setVisionServicesList( | ||
| obj.visionServicesList.map((x) => encodeResourceName(x)) | ||
| ); | ||
| result.setPositionPollingFrequencyHz(obj.positionPollingFrequencyHz); | ||
| result.setObstaclePollingFrequencyHz(obj.obstaclePollingFrequencyHz); | ||
| result.setPlanDeviationM(obj.planDeviationM); | ||
| result.setLinearMPerSec(obj.linearMPerSec); | ||
| result.setAngularDegsPerSec(obj.angularDegsPerSec); | ||
|
|
||
| return result; | ||
| }; |
There was a problem hiding this comment.
That's weird. Why are they required if they're supposed to be optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hotfix-ish - the source code on
maindoes not build properly, even though buf api definitions should be pinned to early version of the motion api. This PR updates our wrappers to use the new motion api so we can build release candidates.