Skip to content

Commit 74bbecb

Browse files
1. Changed request.path to request.path_info in middleware.
2. Deprecation warning for thread setName or getName. 3. Request twice when method not in DRF_API_LOGGER_METHODS. 4. Unicode Escape problem in headers, body and responses.
1 parent 94ff0f1 commit 74bbecb

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# DRF API Logger
2-
![version](https://img.shields.io/badge/version-1.1.10-blue.svg)
2+
![version](https://img.shields.io/badge/version-1.1.11-blue.svg)
33
[![Downloads](https://static.pepy.tech/personalized-badge/drf-api-logger?period=total&units=none&left_color=black&right_color=orange&left_text=Downloads%20Total)](http://pepy.tech/project/drf-api-logger)
44
[![Downloads](https://static.pepy.tech/personalized-badge/drf-api-logger?period=month&units=none&left_color=black&right_color=orange&left_text=Downloads%20Last%20Month)](https://pepy.tech/project/drf-api-logger)
55
[![Downloads](https://static.pepy.tech/personalized-badge/drf-api-logger?period=week&units=none&left_color=black&right_color=orange&left_text=Downloads%20Last%20Week)](https://pepy.tech/project/drf-api-logger)

drf_api_logger/middleware/api_logger_middleware.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import json
22
import time
3-
import bleach
43
from django.conf import settings
54
from django.urls import resolve
65
from django.utils import timezone
@@ -62,8 +61,8 @@ def __call__(self, request):
6261
# Run only if logger is enabled.
6362
if self.DRF_API_LOGGER_DATABASE or self.DRF_API_LOGGER_SIGNAL:
6463

65-
url_name = resolve(request.path).url_name
66-
namespace = resolve(request.path).namespace
64+
url_name = resolve(request.path_info).url_name
65+
namespace = resolve(request.path_info).namespace
6766

6867
# Always skip Admin panel
6968
if namespace == 'admin':
@@ -100,7 +99,7 @@ def __call__(self, request):
10099

101100
# Log only registered methods if available.
102101
if len(self.DRF_API_LOGGER_METHODS) > 0 and method not in self.DRF_API_LOGGER_METHODS:
103-
return self.get_response(request)
102+
return response
104103

105104
if response.get('content-type') in ('application/json', 'application/vnd.api+json',):
106105
if getattr(response, 'streaming', False):

drf_api_logger/start_logger_when_server_starts.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,13 @@
1111
already_exists = False
1212

1313
for t in threading.enumerate():
14-
if t.getName() == LOG_THREAD_NAME:
14+
if t.name == LOG_THREAD_NAME:
1515
already_exists = True
16+
break
1617

1718
if not already_exists:
1819
t = InsertLogIntoDatabase()
1920
t.daemon = True
20-
t.setName(LOG_THREAD_NAME)
21+
t.name = LOG_THREAD_NAME
2122
t.start()
2223
LOGGER_THREAD = t

requirements.txt

1.21 KB
Binary file not shown.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def get_long_desc():
2121

2222
setuptools.setup(
2323
name="drf_api_logger",
24-
version="1.1.10",
24+
version="1.1.11",
2525
author="Vishal Anand",
2626
author_email="[email protected]",
2727
description="An API Logger for your Django Rest Framework project.",

0 commit comments

Comments
 (0)