Another code simplification

Exact same effect: this complicated code was for replacing the last occurrence (there is no built-in function for this), and there is an englobing condition to ensure we replace the substring $op only if it is at the very end of $k.

As a bonus, previous code was missing a preg_quote(), but we no longer need it.

Author: vlakoff

system/Database/BaseBuilder.php

@@ -659,7 +659,7 @@ protected function whereHaving(string $qbKey, $key, $value = null, string $type
                     $op = trim(current($op));
 
                     if (substr($k, -1 * strlen($op)) === $op) {
-                        $k = rtrim(strrev(preg_replace(strrev('/' . $op . '/'), strrev(''), strrev($k), 1)));
+                        $k = rtrim(substr($k, 0, -1 * strlen($op)));
                     }
                     $op = " {$op}";
                 } else {