Reject env files with missmatched quotes

Author: GrahamCampbell

src/Parser.php

@@ -55,7 +55,7 @@ public static function parseValue($value)
      */
     public static function parseQuotedValue($value)
     {
-        $data = array_reduce(str_split($value), function ($data, $char) use ($value) {
+        $result = array_reduce(str_split($value), function ($data, $char) use ($value) {
             switch ($data[1]) {
                 case Parser::INITIAL_STATE:
                     if ($char === '"' || $char === '\'') {
@@ -94,7 +94,13 @@ public static function parseQuotedValue($value)
             }
         }, array('', Parser::INITIAL_STATE));
 
-        return trim($data[0]);
+        if ($result[1] === Parser::QUOTED_STATE || $result[1] === Parser::ESCAPE_STATE) {
+            throw new InvalidFileException(
+                'Dotenv values starting with a quote must finish with a closing quote.'
+            );
+        }
+
+        return trim($result[0]);
     }
 
     /**

tests/Dotenv/DotenvTest.php

@@ -87,7 +87,47 @@ public function testLargeDotenvLoadsEnvironmentVars()
      */
     public function testSpacedValuesWithoutQuotesThrowsException()
     {
-        $dotenv = new Dotenv(dirname(__DIR__).'/fixtures/env-wrong', 'spaced-wrong.env');
+        $dotenv = new Dotenv(dirname(__DIR__).'/fixtures/env', 'spaced-wrong.env');
+        $dotenv->load();
+    }
+
+    /**
+     * @expectedException \Dotenv\Exception\InvalidFileException
+     * @expectedExceptionMessage Dotenv values starting with a quote must finish with a closing quote.
+     */
+    public function testMissingClosingSingleQuoteThrowsException()
+    {
+        $dotenv = new Dotenv(dirname(__DIR__).'/fixtures/env', 'squote-wrong.env');
+        $dotenv->load();
+    }
+
+    /**
+     * @expectedException \Dotenv\Exception\InvalidFileException
+     * @expectedExceptionMessage Dotenv values starting with a quote must finish with a closing quote.
+     */
+    public function testMissingClosingDoubleQuoteThrowsException()
+    {
+        $dotenv = new Dotenv(dirname(__DIR__).'/fixtures/env', 'dquote-wrong.env');
+        $dotenv->load();
+    }
+
+    /**
+     * @expectedException \Dotenv\Exception\InvalidFileException
+     * @expectedExceptionMessage Dotenv values starting with a quote must finish with a closing quote.
+     */
+    public function testMissingClosingQuotesThrowsException()
+    {
+        $dotenv = new Dotenv(dirname(__DIR__).'/fixtures/env', 'quotes-wrong.env');
+        $dotenv->load();
+    }
+
+    /**
+     * @expectedException \Dotenv\Exception\InvalidFileException
+     * @expectedExceptionMessage Dotenv values starting with a quote must finish with a closing quote.
+     */
+    public function testMissingClosingQuoteWithEscapeThrowsException()
+    {
+        $dotenv = new Dotenv(dirname(__DIR__).'/fixtures/env', 'escape-wrong.env');
         $dotenv->load();
     }
 

tests/fixtures/env/dquote-wrong.env

@@ -0,0 +1 @@
+TEST="erert

tests/fixtures/env/escape-wrong.env

@@ -0,0 +1 @@
+TEST="\

tests/fixtures/env/quotes-wrong.env

@@ -0,0 +1,2 @@
+TEST="erert
+TEST='erert

tests/fixtures/env-wrong/spaced-wrong.env renamed to tests/fixtures/env/spaced-wrong.env

@@ -0,0 +1 @@
+TEST='erert