cleaned up health appliance sample

Signed-off-by: aspurohit <[email protected]>

Author: shwetapurohit

samples/vsphere/appliances/health_messages.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 """
 * *******************************************************
-* Copyright (c) VMware, Inc. 2017. All Rights Reserved.
+* Copyright (c) VMware, Inc. 2019. All Rights Reserved.
 * SPDX-License-Identifier: MIT
 * *******************************************************
 *
@@ -13,7 +13,7 @@
 """
 
 __author__ = 'VMware, Inc.'
-__copyright__ = 'Copyright 2017 VMware, Inc. All rights reserved.'
+__copyright__ = 'Copyright 2019 VMware, Inc. All rights reserved.'
 __vcenter_version__ = '6.7+'
 
 from datetime import datetime, date
@@ -30,6 +30,8 @@ class HealthMessages(object):
     """
     Demonstrates getting Health messages for various health items
 
+    such as memory, storage and cpu
+
     Retrieves Health messages details from vCenter and prints the data
 
     """
@@ -40,16 +42,18 @@ def __init__(self):
 
     def setup(self):
         parser = sample_cli.build_arg_parser()
+
         parser.add_argument(
             '--item',
             required=True,
             action='store',
             choices=['memory', 'cpu', 'storage'],
             help='Specify the name of health item to view the messages')
+
         args = sample_util.process_cli_args(parser.parse_args())
         self.item = args.item
 
-    # Connect to vAPI services
+        # Connect to vAPI services
         self.stub_config = vapiconnect.connect(
             host=args.server,
             user=args.username,
@@ -60,25 +64,26 @@ def setup(self):
 
     def run(self):
         message_list = self.health_client.messages(self.item)
-        notification_message = Notification()
+        message = Notification()
         msg = LocalizableMessage()
         print(" Health Alarams")
         print("-------------------\n")
         if not message_list:
             print("No health alarms for : " + self.item)
         else:
-            for notification_message in message_list:
-                print("Alert time : {}".format(notification_message.time))
-                print("Alert message Id: " + notification_message.id)
-                local_message = notification_message.message
-                def_message = local_message.default_message
-                print("Alert message : " + def_message)
+            for message in message_list:
+                print("Alert time : {}".format(message.time))
+                print("Alert message Id: " + message.id)
+                local_message = message.message
+                default_msg = local_message.default_message
+                print("Alert message : " + default_msg)
 
 
 def main():
     health_sample = HealthMessages()
     health_sample.setup()
     health_sample.run()
 
+
 if __name__ == '__main__':
     main()