removing unused imports

Signed-off-by: Anusha Hegde <[email protected]>

Author: anusha94

samples/vmc/networks_nsxt/cgw_firewall_crud.py

@@ -17,7 +17,7 @@
 __vcenter_version__ = '6.8.0+'
 
 import requests
-from samples.vmc.helpers.sample_cli import parser, required_args
+from samples.vmc.helpers.sample_cli import parser
 from com.vmware.nsx_policy_client_for_vmc import create_nsx_policy_client_for_vmc
 from com.vmware.nsx_policy.model_client import IPAddressExpression
 from com.vmware.nsx_policy.model_client import Group

samples/vmc/networks_nsxt/dfw_firewall_crud.py

@@ -17,7 +17,7 @@
 __vcenter_version__ = '6.8.0+'
 
 import requests
-from samples.vmc.helpers.sample_cli import parser, required_args
+from samples.vmc.helpers.sample_cli import parser
 from com.vmware.nsx_policy_client_for_vmc import create_nsx_policy_client_for_vmc
 from com.vmware.nsx_policy.model_client import IPAddressExpression
 from com.vmware.nsx_policy.model_client import Group

samples/vmc/networks_nsxt/hello_world.py

@@ -16,7 +16,7 @@
 __author__ = 'VMware, Inc.'
 
 import pprint
-from samples.vmc.helpers.sample_cli import parser, required_args
+from samples.vmc.helpers.sample_cli import parser
 from com.vmware.nsx_policy_client_for_vmc import (
     create_nsx_policy_client_for_vmc)
 

samples/vmc/networks_nsxt/nat_crud.py

@@ -18,7 +18,7 @@
 
 import requests
 
-from samples.vmc.helpers.sample_cli import parser, required_args
+from samples.vmc.helpers.sample_cli import parser
 from com.vmware.nsx_policy_client_for_vmc import create_nsx_policy_client_for_vmc
 from com.vmware.nsx_vmc_app_client_for_vmc import create_nsx_vmc_app_client_for_vmc
 from com.vmware.nsx_vmc_app.model_client import PublicIp

samples/vmc/networks_nsxt/security_group_delete.py

@@ -19,7 +19,7 @@
 import random
 
 import requests
-from samples.vmc.helpers.sample_cli import parser, required_args, optional_args
+from samples.vmc.helpers.sample_cli import parser, optional_args
 from com.vmware.nsx_policy.infra_client import Domains
 from com.vmware.nsx_policy.model_client import (Expression, Group,
                                                 IPAddressExpression)

samples/vmc/networks_nsxt/security_group_list.py

@@ -18,7 +18,7 @@
 
 import requests
 
-from samples.vmc.helpers.sample_cli import parser, required_args, optional_args
+from samples.vmc.helpers.sample_cli import parser, optional_args
 from com.vmware.nsx_policy.infra_client import Domains
 from com.vmware.nsx_policy_client_for_vmc import create_nsx_policy_client_for_vmc
 from vmware.vapi.bindings.struct import PrettyPrinter

samples/vmc/networks_nsxt/segments_firewall_crud.py

@@ -16,7 +16,7 @@
 __author__ = 'VMware, Inc.'
 
 import requests
-from samples.vmc.helpers.sample_cli import parser, required_args
+from samples.vmc.helpers.sample_cli import parser
 from com.vmware.nsx_policy_client_for_vmc import create_nsx_policy_client_for_vmc
 from com.vmware.nsx_policy.model_client import Rule
 from vmware.vapi.bindings.struct import PrettyPrinter as NsxPrettyPrinter

samples/vmc/networks_nsxv/dns_crud.py

@@ -15,7 +15,7 @@
 
 __author__ = 'VMware, Inc.'
 
-from samples.vmc.helpers.sample_cli import parser, required_args, optional_args
+from samples.vmc.helpers.sample_cli import parser, optional_args
 from com.vmware.vmc.model_client import DnsForwarders
 from vmware.vapi.vmc.client import create_vmc_client
 

samples/vmc/networks_nsxv/firewall_rules_crud.py

@@ -14,7 +14,7 @@
 
 __author__ = 'VMware, Inc.'
 
-from samples.vmc.helpers.sample_cli import parser, required_args, optional_args
+from samples.vmc.helpers.sample_cli import parser, optional_args
 from com.vmware.vmc.model_client import (AddressFWSourceDestination,
                                          Application, FirewallRules,
                                          Nsxfirewallrule, Nsxfirewallservice)

samples/vmc/networks_nsxv/ipsec_vpns_crud.py

@@ -14,7 +14,7 @@
 
 __author__ = 'VMware, Inc.'
 
-from samples.vmc.helpers.sample_cli import parser, required_args, optional_args
+from samples.vmc.helpers.sample_cli import parser, optional_args
 from com.vmware.vmc.model_client import Ipsec, IpsecSite, IpsecSites, Subnets
 from vmware.vapi.vmc.client import create_vmc_client
 

samples/vmc/networks_nsxv/logical_network_crud.py

@@ -14,7 +14,7 @@
 
 __author__ = 'VMware, Inc.'
 
-from samples.vmc.helpers.sample_cli import parser, required_args, optional_args
+from samples.vmc.helpers.sample_cli import parser, optional_args
 from com.vmware.vmc.model_client import (L2Extension, SddcNetwork,
                                          SddcNetworkAddressGroups,
                                          SddcNetworkAddressGroup,

samples/vmc/networks_nsxv/nat_rule_crud.py

@@ -14,7 +14,7 @@
 
 __author__ = 'VMware, Inc.'
 
-from samples.vmc.helpers.sample_cli import parser, required_args, optional_args
+from samples.vmc.helpers.sample_cli import parser, optional_args
 from com.vmware.vmc.model_client import Nsxnatrule, NatRules
 from vmware.vapi.vmc.client import create_vmc_client
 

samples/vmc/networks_nsxv/public_ip_crud.py

@@ -14,7 +14,7 @@
 
 __author__ = 'VMware, Inc.'
 
-from samples.vmc.helpers.sample_cli import parser, required_args, optional_args
+from samples.vmc.helpers.sample_cli import parser, optional_args
 from com.vmware.vmc.model_client import SddcAllocatePublicIpSpec
 from vmware.vapi.vmc.client import create_vmc_client
 

samples/vmc/sddc/add_remove_hosts.py

@@ -18,7 +18,7 @@
 import atexit
 import requests
 
-from samples.vmc.helpers.sample_cli import parser, required_args, optional_args
+from samples.vmc.helpers.sample_cli import parser, optional_args
 from com.vmware.vmc.model_client import EsxConfig, ErrorResponse
 from com.vmware.vapi.std.errors_client import InvalidRequest
 from vmware.vapi.vmc.client import create_vmc_client

samples/vmc/sddc/connect_to_vsphere_with_default_sddc_password.py

@@ -19,7 +19,7 @@
 from com.vmware.vapi.std.errors_client import NotFound
 from com.vmware.vmc.model_client import ErrorResponse
 from six.moves.urllib import parse
-from samples.vmc.helpers.sample_cli import parser, required_args
+from samples.vmc.helpers.sample_cli import parser
 from vmware.vapi.vmc.client import create_vmc_client
 from vmware.vapi.vsphere.client import create_vsphere_client
 

samples/vmc/sddc/sddc_crud.py

@@ -33,8 +33,7 @@ class CreateDeleteSDDC(object):
     """
 
     def __init__(self):
-        parser = argparse.ArgumentParser(
-        description='Standard Arguments for talking to vCenter')
+        parser = argparse.ArgumentParser()
 
         required_args = parser.add_argument_group(
             'required arguments')

samples/vmc/tasks/cancel_task.py

@@ -26,7 +26,7 @@
 """
 
 parser = argparse.ArgumentParser(
-        description='Standard Arguments for talking to vCenter')
+        formatter_class=argparse.ArgumentDefaultsHelpFormatter)
 
 required_args = parser.add_argument_group(
         'required arguments')

samples/vmc/tasks/list_tasks.py

@@ -13,7 +13,7 @@
 
 __author__ = 'VMware, Inc.'
 
-from samples.vmc.helpers.sample_cli import parser, required_args
+import argparse
 from com.vmware.vmc.model_client import Task
 from vmware.vapi.vmc.client import create_vmc_client
 
@@ -28,7 +28,7 @@
             Task.STATUS_FAILED, Task.STATUS_CANCELED]
 
 parser = argparse.ArgumentParser(
-        description='Standard Arguments for talking to vCenter')
+        formatter_class=argparse.ArgumentDefaultsHelpFormatter)
 
 required_args = parser.add_argument_group(
         'required arguments')

samples/vmc/tasks/list_tasks_stg.py

@@ -28,7 +28,7 @@
             Task.STATUS_FAILED, Task.STATUS_CANCELED]
 
 parser = argparse.ArgumentParser(
-        description='Standard Arguments for talking to vCenter')
+        formatter_class=argparse.ArgumentDefaultsHelpFormatter)
 
 required_args = parser.add_argument_group(
         'required arguments')

samples/vsphere/common/sample_cli.py

@@ -35,14 +35,17 @@ def build_arg_parser():
             'required arguments')
     required_args.add_argument('-s', '--server',
                         action='store',
+                        required=True,
                         help='vSphere service IP to connect to')
 
     required_args.add_argument('-u', '--username',
                         action='store',
+                        required=True,
                         help='Username to use when connecting to vc')
 
     required_args.add_argument('-p', '--password',
                         action='store',
+                        required=True,
                         help='Password to use when connecting to vc')
 
     parser.add_argument('-c', '--cleardata',