Skip to content

Commit c888184

Browse files
committed
Sample is not failing if Cluster Name argument passed is not Valid.Assering Cluster presense in setup method instead of execution method
1 parent f4c82a3 commit c888184

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

samples/vsphere/tagging/tagging_workflow.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,12 @@ def _setup(self):
9797
if self.servicemanager is None:
9898
self.servicemanager = self.get_service_manager()
9999

100+
# Finding if Cluster Name passed is Valid
101+
print('finding the cluster {0}'.format(self.cluster_name))
102+
self.cluster_moid = get_cluster_id(service_manager=self.servicemanager, cluster_name=self.cluster_name)
103+
assert self.cluster_moid is not None
104+
print('Found cluster:{0} mo_id:{1}'.format(self.cluster_name, self.cluster_moid))
105+
100106
self.category_svc = Category(self.servicemanager.stub_config)
101107
self.tag_svc = Tag(self.servicemanager.stub_config)
102108
self.tag_association = TagAssociation(self.servicemanager.stub_config)
@@ -119,7 +125,8 @@ def _execute(self):
119125
print('No Tag Found...')
120126

121127
print('creating a new tag category...')
122-
self.category_id = self.create_tag_category(self.category_name, self.category_desc, CategoryModel.Cardinality.MULTIPLE)
128+
self.category_id = self.create_tag_category(self.category_name, self.category_desc,
129+
CategoryModel.Cardinality.MULTIPLE)
123130
assert self.category_id is not None
124131
print('Tag category created; Id: {0}'.format(self.category_id))
125132

@@ -133,11 +140,6 @@ def _execute(self):
133140
self.update_tag(self.tag_id, 'Server Tag updated at ' + date_time)
134141
print('Tag updated; Id: {0}'.format(self.tag_id))
135142

136-
print('finding the cluster {0}'.format(self.cluster_name))
137-
self.cluster_moid = get_cluster_id(service_manager=self.servicemanager, cluster_name=self.cluster_name)
138-
assert self.cluster_moid is not None
139-
print('Found cluster:{0} mo_id:{1}'.format('vAPISDKCluster', self.cluster_moid))
140-
141143
print('Tagging the cluster {0}...'.format(self.cluster_name))
142144
self.dynamic_id = DynamicID(type='ClusterComputeResource', id=self.cluster_moid)
143145
self.tag_association.attach(tag_id=self.tag_id, object_id=self.dynamic_id)

0 commit comments

Comments
 (0)